Skip to content

fix(ci): drop double release-plz update from release:pr#276

Merged
zeitlinger merged 1 commit into
mainfrom
fix/release-plz-no-double-update
May 8, 2026
Merged

fix(ci): drop double release-plz update from release:pr#276
zeitlinger merged 1 commit into
mainfrom
fix/release-plz-no-double-update

Conversation

@zeitlinger

Copy link
Copy Markdown
Member

Summary

  • Drop #MISE depends=["release:update"] from .mise/tasks/release/pr.

Why

release-plz release-pr already runs update internally. Chaining release:update as a depends made every CI run bump and regenerate the changelog twice.

Visible symptom: release PR #242 currently shows v0.23.0 with every PR since project start in the changelog. The first successful release-plz run after #274 merged actually computed the right thing — the run log shows:

INFO determining next version for flint 0.21.0
INFO flint: next version is 0.22.0
* flint: 0.21.0 -> 0.22.0

…and then the chained second update (via release-plz release-pr's internal call) bumped 0.22.0 → 0.23.0 on top of an already-bumped tree, regenerating the whole CHANGELOG.

release:update stays available for local manual previews.

After merge

The next push to main should refresh #242 to v0.22.0 with only commits since v0.21.0.

Test plan

  • CI green on this PR
  • After merge, release PR chore: release v0.22.0 #242 retitles to chore: release v0.22.0 and changelog scope shrinks to commits since v0.21.0

release-plz release-pr already runs update internally. Chaining
release:update as a depends made every CI run bump twice and
regenerate the changelog twice, which is why release PR #242
ended up at v0.23.0 with every PR since project start in the
changelog (instead of v0.22.0 with just commits since v0.21.0).

release:update stays available for local manual previews.
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@zeitlinger zeitlinger marked this pull request as ready for review May 8, 2026 14:17
Copilot AI review requested due to automatic review settings May 8, 2026 14:17
@zeitlinger zeitlinger requested a review from a team as a code owner May 8, 2026 14:17
@zeitlinger zeitlinger enabled auto-merge (squash) May 8, 2026 14:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the release PR automation task to avoid running release-plz update twice during CI-driven release PR updates.

Changes:

  • Removes the release:update dependency from the .mise release:pr task to prevent a second update run during release-plz release-pr.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .mise/tasks/release/pr
Comment on lines 1 to 4
#!/usr/bin/env bash
#MISE description="Open or update the release PR"
#MISE depends=["release:update"]
#USAGE flag "--git-token <token>" help="GitHub token used by release-plz"

@zeitlinger zeitlinger merged commit b987290 into main May 8, 2026
17 checks passed
@zeitlinger zeitlinger deleted the fix/release-plz-no-double-update branch May 8, 2026 14:23
@github-actions github-actions Bot mentioned this pull request May 8, 2026
@github-actions github-actions Bot mentioned this pull request May 8, 2026
zeitlinger pushed a commit that referenced this pull request May 11, 2026
## 🤖 New release

* `flint`: 0.21.0 -> 0.22.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.22.0](v0.21.0...v0.22.0)
- 2026-05-11

### Added

- replace codespell with typos
([#269](#269))
- *(lychee)* add local cache for local runs
([#268](#268))

### Fixed

- *(renovate-deps)* surface real renovate failure in error output
([#278](#278))
- *(ci)* drop double release-plz update from release:pr
([#276](#276))
- *(init)* normalize node runtime before linters
([#267](#267))
- *(renovate)* support block-scalar mise sha256 values
([#266](#266))
- *(mise)* migrate flint-managed tools to supported backends
([#258](#258))
- validate renovate dependency rule coverage
([#263](#263))
- make flint-setup state-based
([#252](#252))
- *(init)* let rustfmt own Rust line length
([#250](#250))
- run renovate-deps for deleted tracked files
([#247](#247))
- validate CI env and isolate check types
([#253](#253))
- *(init)* remove stale head sha from CI snippets
([#248](#248))
- *(init)* enable yamllint indentation rule
([#251](#251))

### Other

- streamline README getting started
([#280](#280))
- *(deps)* update taiki-e/install-action digest to fa0dd4c
([#282](#282))
- *(deps)* lock file maintenance
([#285](#285))
- *(deps)* update dependency mise to v2026.5.2
([#284](#284))
- *(deps)* update dependency go to v1.26.3
([#283](#283))
- *(deps)* update taiki-e/install-action digest to e3134ec
([#281](#281))
- pass git-token and forge to release-plz
([#274](#274))
- *(deps)* update taiki-e/install-action digest to 3fa6878
([#275](#275))
- *(deps)* bump renovate to 43.150.0
([#273](#273))
- [**breaking**] drop --fast-only flag and tighten renovate-deps timing
([#270](#270))
- *(deps)* update rust crate tokio to v1.52.2
([#272](#272))
- upgrade lychee to v0.24.2
([#265](#265))
- *(deps)* update taiki-e/install-action digest to cca35ed
([#254](#254))
- *(deps)* update dependency aqua:owenlamont/ryl to v0.8.0
([#261](#261))
- *(deps)* update dependency mise to v2026.4.28
([#262](#262))
- *(deps)* update dependency golangci-lint to v2.12.1
([#264](#264))
- *(deps)* update dependency aqua:owenlamont/ryl to v0.7.0
([#259](#259))
- *(renovate)* simplify quickstart and batch weekly linter updates
([#257](#257))
- *(deps)* update dependency npm:renovate to v43.141.6
([#255](#255))
- expand positioning and comparisons
([#239](#239))
- *(deps)* update taiki-e/install-action digest to 1f2425c
([#246](#246))
- move release-plz flow into mise tasks
([#234](#234))
- *(deps)* update taiki-e/install-action digest to 481c34c
([#231](#231))
- *(deps)* update dependency ruff to v0.15.12
([#245](#245))
- *(deps)* update dependency npm:renovate to v43.141.5
([#244](#244))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants