Skip to content

Add mixin for OpenRouter#1612

Open
ishanjainn wants to merge 1 commit into
masterfrom
openrouter
Open

Add mixin for OpenRouter#1612
ishanjainn wants to merge 1 commit into
masterfrom
openrouter

Conversation

@ishanjainn

Copy link
Copy Markdown
Contributor

@ishanjainn ishanjainn requested a review from a team as a code owner March 25, 2026 12:11

@Dasomeone Dasomeone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to really comment on this one, feels very barebones with a bunch of identifiers and selectors missing? Did you commit everything you intended to?

"instant": false,
"limit": 20,
"metricsQueryType": "range",
"query": "{ } | count_over_time()",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing identifier for the span?

"instant": false,
"limit": 20,
"metricsQueryType": "range",
"query": "{ status = error } | count_over_time()",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, no limiter to make it openrouter specific? Or am I missing something obvious here? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants