chore: Modernize mongodb-mixin by mariaalons · Pull Request #1629 · grafana/jsonnet-libs

mariaalons · 2026-04-23T10:07:02Z

Update the MongoDB mixin to match the modernized mixins:

Replace hand-written dashboard JSON with generated dashboards
Add MongoDB Overview dashboard
Add conditional MongoDB Logs dashboard (enableLokiLogs flag)
Update jsonnetfile to grafonnet v11.4.0
Use signals

cla-assistant · 2026-04-23T10:07:19Z

All committers have signed the CLA.

cla-assistant · 2026-04-23T10:07:20Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Dasomeone

Seeing myself blind on these queries, going to have to get back to this PR on Monday, but for now here's my comments so far :)

…ons/modernize-mongodb-mixin

Dasomeone

Thanks for the updates Maria! We'll definitely want to update the sample-app in lockstep with this as currently it doesn't cover appropriately to test/validate

Dasomeone · 2026-05-07T11:59:58Z

+      },
+      replicaSetState: {
+        name: 'Replica set state',
+        description: 'An integer between 0 and 10 that represents the replica state of the current member.',


This would benefit to a link to the source/definition of what the 0-10 states mean or represent

…ons/modernize-mongodb-mixin

… grouping

…ons/modernize-mongodb-mixin

Dasomeone

Great progress, but we'll need to iron out the customAllValue as it's causing some issues. Basically we'll probably want to either have hardcoded values, or a very specific customAllValues just for the logs lib as it currently affects the main mixin, but not the logs lib for whatever reason

Dasomeone · 2026-06-30T12:49:09Z

+        '1': { index: 1, text: 'PRIMARY' },
+        '2': { index: 2, text: 'SECONDARY' },


These two may need/benefit from a slightly more descriptive healthy state, given they already have y-axis that label them as primary/secondary.

I'm thinking perhaps HEALTHY (PRIMARY) or PRIMARY - Healthy, or similar.

Much nicer now, but I just realised I'd forgotten to comment that there's a duplicate "replica set states" on each set. Might want to drop it since it's already in the title

Dasomeone · 2026-06-30T12:50:35Z

+      + g.panel.stat.options.reduceOptions.withCalcs(['lastNotNull'])
+      + g.panel.stat.options.withGraphMode('none'),
+
+    replicasetVersions:


Slight nit on column naming here, might benefit from some cleanup so it's not just the label names?

Not 100% sold on this, so feel free to push back :D

Dasomeone · 2026-06-30T12:51:24Z

+      )
+      + g.panel.timeSeries.standardOptions.withUnit('s'),
+
+    replicasetMemberPing:


Duplicate primary/secondary in the legends on this panel

Dasomeone · 2026-06-30T12:53:26Z

+    overviewInstanceStates:
+      commonlib.panels.generic.statusHistory.base.new(
+        'Instance states',
+        targets=[signals.overview.replicaSetStateByInstance.asTarget()],
+        description='Replica set state per instance over time.'
+      )
+      + g.panel.statusHistory.standardOptions.withMappings([replicaSetStateMappings])
+      + g.panel.statusHistory.options.withShowValue('auto'),
+


I think you'll need to adjust the visualisation for this panel slightly, seems a little unwieldy.

Perhaps cleaning up the number display and y axis might help?

Dasomeone · 2026-06-30T13:06:14Z

This entire dashboard is broken due to the .+ allvalue currently

mariaalons · 2026-07-01T15:12:53Z

@Dasomeone Thank you for the thorough review 🙏 I applied the requested changes 🙇

Dasomeone

Couple more comments, I think some of this is just due to sample-app loadgen/coverage but the cluster dashboard definitely is still broken

Dasomeone · 2026-07-02T12:10:08Z

+
+    replicasetAvgLag:
+      commonlib.panels.generic.stat.base.new(
+        'Average replica set lag',


another legend issue here

Dasomeone · 2026-07-02T12:10:34Z

+    replicasetMembers:
+      commonlib.panels.generic.stat.base.new(
+        'Replica set members',


Legend issue

Dasomeone · 2026-07-02T12:11:17Z

+
+    replicasetOplogRecoveryWindow:
+      commonlib.panels.generic.timeSeries.base.new(
+        'Oplog recovery window',


Missing service name info or hostname in legend.

No data for the rest of the oplog panels so can't verify, but might extend to all of them

Dasomeone · 2026-07-02T12:12:24Z

+      percona_mongodb: 'mongodb_up',
+    },
+    signals: {
+      uptime: {


Duplicate "uptime" mention in all legends

Dasomeone · 2026-07-02T12:13:12Z

+          },
+        },
+      },
+      replicaSetState: {


Interesting value mapping issue here, you may need to break out the shards individually

Dasomeone · 2026-07-02T12:14:06Z

+      commonlib.panels.generic.stat.base.new(
+        'Latency',
+        targets=[signals.instance.commandLatency.asTarget()],
+        description='Average command latency.'


Is latency not covered by the updated sample app?

Dasomeone · 2026-07-02T12:14:31Z

+        description='Average command latency.'
+      )
+      + g.panel.stat.standardOptions.withUnit('µs')
+      + g.panel.stat.options.reduceOptions.withCalcs(['lastNotNull'])
+      + g.panel.stat.options.withGraphMode('none'),
+
+    instanceReplicaSetStateGauge:
+      commonlib.panels.generic.stat.base.new(
+        'Current replica set state',
+        targets=[signals.instance.replicaSetState.asTarget()],
+        description='Current state of the replica set member.'
+      )
+      + g.panel.stat.standardOptions.withMappings([replicaSetStateMappings])
+      + g.panel.stat.standardOptions.withDisplayName('${__field.labels.service_name}')
+      + g.panel.stat.options.withGraphMode('none')
+      + g.panel.stat.standardOptions.color.withMode('thresholds')
+      + g.panel.stat.standardOptions.thresholds.withSteps([
+        g.panel.stat.standardOptions.threshold.step.withColor('green')
+        + g.panel.stat.standardOptions.threshold.step.withValue(null),
+        g.panel.stat.standardOptions.threshold.step.withColor('green')
+        + g.panel.stat.standardOptions.threshold.step.withValue(1),
+        g.panel.stat.standardOptions.threshold.step.withColor('blue')
+        + g.panel.stat.standardOptions.threshold.step.withValue(2),
+        g.panel.stat.standardOptions.threshold.step.withColor('orange')
+        + g.panel.stat.standardOptions.threshold.step.withValue(3),
+        g.panel.stat.standardOptions.threshold.step.withColor('red')
+        + g.panel.stat.standardOptions.threshold.step.withValue(8),
+      ])
+      + g.panel.stat.options.reduceOptions.withCalcs(['lastNotNull']),
+
+    instanceCommandOps:
+      commonlib.panels.generic.timeSeries.base.new(
+        'Command operations',
+        targets=[
+          signals.instance.opCountersTotal.asTarget(),
+          signals.instance.opCountersReplTotal.asTarget(),
+          signals.instance.ttlDeletedDocuments.asTarget(),
+        ],
+        description='Rate of command operations by type.'
+      )
+      + withStacking
+      + g.panel.timeSeries.standardOptions.withUnit('ops'),
+
+    instanceConnections:


Missing instance detail in legend

Dasomeone · 2026-07-02T12:15:15Z

I won't comment on it throughout, but most if not all the panels in this dashboard are missing instance detail in the legends. A little hard to validate due to sample-app coverage (might need more comprehensive load-gen?)

Dasomeone · 2026-07-02T12:16:30Z

Still largely broken on latest sample-app

Dasomeone · 2026-07-02T12:18:50Z

+      commonlib.panels.generic.timeSeries.base.new(
+        'Shard services QPS - $shard',
+        targets=[signals.cluster.shardServicesQps.asTarget()],
+        description='Queries per second for shard services.'
+      )
+      + withTableLegend
+      + g.panel.timeSeries.standardOptions.withUnit('ops')
+      + g.panel.timeSeries.panelOptions.withRepeat('shard'),
+


Nothing wrong here, just wanted to comment and say I like it. Only downside is this can result in some whitespace on odd configurations/amounts of replicasets but that's acceptable

chore: Modernize mongodb-mixin

54ee450

Dasomeone reviewed Apr 24, 2026

View reviewed changes

Comment thread mongodb-mixin/.lint Outdated

Comment thread mongodb-mixin/dashboards.libsonnet

Comment thread mongodb-mixin/rows.libsonnet

Comment thread mongodb-mixin/signals/cluster.libsonnet Outdated

mariaalons added 5 commits April 28, 2026 09:26

fix legend labels and show 0 when no instances are up

35abe58

Merge branch 'master' of github.com:grafana/jsonnet-libs into mariaal…

5a0e04c

…ons/modernize-mongodb-mixin

Address review comments

f926f79

Merge branch 'master' of github.com:grafana/jsonnet-libs into mariaal…

802367e

…ons/modernize-mongodb-mixin

fix MongodbTooManyConnections alert and expand README

279858f

Dasomeone reviewed May 7, 2026

View reviewed changes

mariaalons added 3 commits May 12, 2026 16:51

Apply review feedback

86f3f78

adapt alerts to use signals

1a78e36

Merge branch 'master' of github.com:grafana/jsonnet-libs into mariaal…

093d6dd

…ons/modernize-mongodb-mixin

mariaalons mentioned this pull request May 15, 2026

common-lib: extract reusable panel-option builders (table legend, stat defaults) #1637

Open

mariaalons added 4 commits June 4, 2026 17:27

Merge branch 'master' of github.com:grafana/jsonnet-libs into mariaal…

2fa6cf2

…ons/modernize-mongodb-mixin

Merge branch 'master' of github.com:grafana/jsonnet-libs into mariaal…

c0b6bc9

…ons/modernize-mongodb-mixin

fix(mongodb): logs dashboard Loki import + replication headroom alert…

9fd5b53

… grouping

Merge branch 'master' of github.com:grafana/jsonnet-libs into mariaal…

1d31524

…ons/modernize-mongodb-mixin

mariaalons marked this pull request as ready for review June 26, 2026 15:04

mariaalons requested a review from a team as a code owner June 26, 2026 15:04

Dasomeone requested changes Jun 30, 2026

View reviewed changes

fix(mongodb): scope customAllValue to logs and apply review fixes

b3bfa0a

Dasomeone reviewed Jul 2, 2026

View reviewed changes

		'1': { index: 1, text: 'PRIMARY' },
		'2': { index: 2, text: 'SECONDARY' },

Uh oh!

Conversation

mariaalons commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-assistant Bot commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-assistant Bot commented Apr 23, 2026

Uh oh!

Dasomeone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dasomeone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Dasomeone left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mariaalons commented Jul 1, 2026

Uh oh!

Dasomeone left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

mariaalons commented Apr 23, 2026 •

edited

Loading

cla-assistant Bot commented Apr 23, 2026 •

edited

Loading