chore: Modernize signals istio-mixin#1665
Draft
postnati wants to merge 3 commits into
Draft
Conversation
|
|
prometheusAlerts used a single colon (+:), making it a visible field. Grizzly's mixin wrapper merges the raw mixin object back into its output, so the visible prometheusAlerts.groups leaked in and failed the resource walker (kind/metadata/spec missing). Hidden field (+::) matches grafanaDashboards and every other mixin; alert generation is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes istio-mixin to use the signals architecture pattern.