feat: support memory profiling by adding ProfileType#565
Draft
xavilien wants to merge 4 commits into
Draft
Conversation
Extend grafana-renovate-config base preset (grafana#556)
| let (type_name, unit_name) = profiling_type.value_type(); | ||
| let st = b.add_string(&type_name.to_string()); | ||
| let unit = b.add_string(&unit_name.to_string()); | ||
| b.profile.sample_type.push(ValueType { r#type: st, unit }); |
Contributor
There was a problem hiding this comment.
memory profile code does not use PprofBuilder - it is encoded to pprof in another crate and we just transfer it with ReportData::RawPprof
| pub tenant_id: Option<String>, | ||
| pub http_headers: HashMap<String, String>, | ||
| pub upload_interval: Duration, | ||
| pub profiling_type: ProfilingType, |
Contributor
There was a problem hiding this comment.
I am not sure it should be a config option. I would expect it to be provided by the backend or profiling subssytem. We pass ReportBatch.profile_type now.
Contributor
|
I dont' understand the problem this PR is trying to solve. Can you explain a bit more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only CPU is supported in this SDK. This PR adds support for memory profiling by adding a new ProfileType to PyroscopeConfig, which is used by pprof::encode to configure the report sent to the pyroscope server. Closes #564.