Add missing default permissions for Store manager role on install#739
Open
KrzysztofPajak wants to merge 1 commit into
Open
Add missing default permissions for Store manager role on install#739KrzysztofPajak wants to merge 1 commit into
KrzysztofPajak wants to merge 1 commit into
Conversation
New Grand.Web.Store controllers (Customers, Settings, Payment, Customer/Address/Contact attributes, Shipping/Tax, Currencies, Discounts, Gift vouchers, Languages, Email accounts, Message templates, Pages) were never reflected in the default permission set granted to the Store manager customer group during installation, so freshly installed store owners could not reach them. Only affects new installations; existing installs are not migrated.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StoreManagercustomer group) functionality inGrand.Web.Storegrew significantly (per-store Customers, Settings, Payment methods/settings/restrictions, Customer/Address/Contact attributes, Shipping, Tax, Currencies, Discounts, Gift vouchers, Languages, Email accounts, Message templates, Pages), but the default permission set granted to that role at install time was never updated.ManageAccessStoreManagerPanel(the panel gate) was already granted.StandardPermissionentries to theStoreManagerblock inPermissionExtensions.DefaultPermissions().ManageDocuments(Documents tab is intentionally hidden for store managers),ManagePluginsandManageMessageQueue(system-level/global concerns, not per-store).Test plan
/Store