feat: Add user defined openai model provider (#124)#125
Merged
grapeot merged 1 commit intograpeot:masterfrom Apr 9, 2025
Merged
feat: Add user defined openai model provider (#124)#125grapeot merged 1 commit intograpeot:masterfrom
grapeot merged 1 commit intograpeot:masterfrom
Conversation
Change-Id: Ice3c42381021e474d751528a0b5c4726998a6acb Signed-off-by: MiaoDX <miaodx@hotmail.com>
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .env.example: Language not supported
Comments suppressed due to low confidence (2)
tools/llm_api.py:71
- Consider validating or normalizing the base_url to ensure it adheres to the expected URL format. This can help avoid runtime issues with misconfigured endpoints.
base_url = os.getenv('OPENAI_BASE_URL', "https://api.openai.com/v1")
tools/llm_api.py:145
- Review the default model fallback to ensure 'gpt-4o' matches the expected model identifier for the provider. Confirm that this behavior is aligned with the overall configuration strategy.
model = os.getenv('OPENAI_MODEL_DEPLOYMENT', 'gpt-4o')
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Ice3c42381021e474d751528a0b5c4726998a6acb
Hi,
I am using other OpenAI model providers, with custom base_url and model. So, it should be nice to be configurable and won't hurt others.
And, inside
llm_api.pyandweb_scraper.py, change to use python3 directly, to be consistent with other tools.