Fixes for windows installation#2117
Open
kim-ep wants to merge 7 commits intographcommerce-org:canaryfrom
Open
Conversation
- escape spaces in command line with double quotes - support glob pattern in `rimraf` (disabled for Windows by default) - replace back slashes with forward slashes when POSIX-style path is implied
🦋 Changeset detectedLatest commit: 4b3b47d The changes in this PR will be included in the next version bump. This PR includes changesets to release 73 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… only to the canary branch)
# Conflicts: # yarn.lock
Member
|
@kim-ep I've tried adding a windows build to github actions, lets see if that works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some fixes to GraphCommerce source code that allowed to install it on Windows 11 without using WSL.
List of changes:
rimrafpackage (it's disabled by default for Windows)Unfortunately, changes related to back slashes are masked by code reformatting forced by Prettier.
In
findPlugins.tsonly one change is meaningful, in the line 68:In
generateInterceptors.tsonly one change is meaningful, in the line 215: