Skip to content

IReadOnlyDictionry is not a list type #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shane32 merged 2 commits into from
Feb 11, 2025
Merged

IReadOnlyDictionry is not a list type #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
540fedc
IReadOnlyDictionry is not a list type
Jan 22, 2025
4795b65
change target framework for tests
Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/GraphQL.Conventions/Types/Resolution/Extensions/ReflectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ public static bool IsPrimitiveGraphType(this TypeInfo type)

public static bool IsEnumerableGraphType(this TypeInfo type)
{
if (type.IsImplementingInterface(typeof(IDictionary)) || type.IsImplementingInterface(typeof(IDictionary<,>)))
if (type.IsImplementingInterface(typeof(IDictionary))
|| type.IsImplementingInterface(typeof(IDictionary<,>))
|| type.IsImplementingInterface(typeof(IReadOnlyDictionary<,>)))
{
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion test/GraphQL.Conventions.Tests/GraphQL.Conventions.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net7.0</TargetFramework>
<StartupObject>Tests.Program</StartupObject>
<RootNamespace>Tests</RootNamespace>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions test/GraphQL.Conventions.Tests/Types/Resolution/Extensions/ReflectionExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public void IsEnumerableGraphType_Should_Return_False_For_Common_Dictionary_Type
{
typeof(IDictionary<,>),
typeof(IDictionary),
typeof(IReadOnlyDictionary<,>)
};

[Theory]
Expand Down