Skip to content

run CI for #8100#8101

Closed
n1ru4l wants to merge 2 commits into
mainfrom
fix/apt-upgrade-base-image-cves
Closed

run CI for #8100#8101
n1ru4l wants to merge 2 commits into
mainfrom
fix/apt-upgrade-base-image-cves

Conversation

@n1ru4l

@n1ru4l n1ru4l commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Rick Bijkerk added 2 commits June 2, 2026 12:04
The service, migrations and CLI Dockerfiles ran apt-get update followed
only by apt-get install of a few specific packages, so Debian security
patches inherited from the pinned node:*-slim base image were never
applied. Add apt-get upgrade so published images pick up fixed OS
packages at build time.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds apt-get upgrade to the CLI, migrations, and services Dockerfiles. To prevent builds from hanging in non-interactive environments like CI, prepend DEBIAN_FRONTEND=noninteractive to the apt-get commands.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker/cli.dockerfile
FROM node:24.14.1-slim

RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates git && rm -rf /var/lib/apt/lists/*
RUN apt-get update && apt-get upgrade -y --no-install-recommends && apt-get install -y --no-install-recommends ca-certificates git && rm -rf /var/lib/apt/lists/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Running apt-get upgrade can sometimes trigger interactive prompts (e.g., for configuration choices or service restarts), which can cause the Docker build to hang or fail in non-interactive environments like CI. Prepend DEBIAN_FRONTEND=noninteractive to ensure the commands run without prompting.

RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get upgrade -y --no-install-recommends && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends ca-certificates git && rm -rf /var/lib/apt/lists/*

FROM node:24.14.1-slim

RUN apt-get update && apt-get install -y ca-certificates
RUN apt-get update && apt-get upgrade -y --no-install-recommends && apt-get install -y --no-install-recommends ca-certificates && rm -rf /var/lib/apt/lists/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Running apt-get upgrade can sometimes trigger interactive prompts, which can cause the Docker build to hang or fail in non-interactive environments like CI. Prepend DEBIAN_FRONTEND=noninteractive to ensure the commands run without prompting.

RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get upgrade -y --no-install-recommends && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends ca-certificates && rm -rf /var/lib/apt/lists/*

FROM node:24.14.1-slim

RUN apt-get update && apt-get install -y wget ca-certificates && rm -rf /var/lib/apt/lists/*
RUN apt-get update && apt-get upgrade -y --no-install-recommends && apt-get install -y --no-install-recommends wget ca-certificates && rm -rf /var/lib/apt/lists/*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Running apt-get upgrade can sometimes trigger interactive prompts, which can cause the Docker build to hang or fail in non-interactive environments like CI. Prepend DEBIAN_FRONTEND=noninteractive to ensure the commands run without prompting.

RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get upgrade -y --no-install-recommends && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends wget ca-certificates && rm -rf /var/lib/apt/lists/*

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
hive 11.2.1-alpha-20260602103123-3c8f188bc3ff7568f6d6fce8757927ccc5b9f40f npm ↗︎ unpkg ↗︎

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

🐋 This PR was built and pushed to the following Docker images:

Targets: build

Platforms: linux/amd64

Image Tag: 3c8f188bc3ff7568f6d6fce8757927ccc5b9f40f

@n1ru4l n1ru4l closed this Jun 8, 2026
@n1ru4l n1ru4l deleted the fix/apt-upgrade-base-image-cves branch June 8, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant