Skip to content

feat: show criticalityReason context for safe schema changes based on usage #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenishasubedi05 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: show criticalityReason context for safe schema changes based on usage #8182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
367dff5
feat: show criticalityReason in schema check UI for safe changes base…
jenishasubedi05 Jun 22, 2026
f558735
chore: regenerate graphql types after adding criticalityReason
jenishasubedi05 Jun 22, 2026
49500c3
fix: address PR review feedback - remove build artifacts, fix indenta…
jenishasubedi05 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion docker/docker-compose.dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ services:
retries: 3
volumes:
- ./.hive-dev/clickhouse/logs:/var/log/clickhouse-server
- ./.hive-dev/clickhouse/db:/var/lib/clickhouse
- clickhouse_data:/var/lib/clickhouse
- ./configs/clickhouse:/etc/clickhouse-server/conf.d
ports:
- '8123:8123'
Expand Down Expand Up @@ -281,3 +281,6 @@ services:

networks:
stack: {}

volumes:
clickhouse_data:
4 changes: 2 additions & 2 deletions packages/libraries/external-composition/build-example.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
/* eslint-disable */
import { readFileSync } from 'fs';
import { dirname, join } from 'path';
import { dirname, join, sep } from 'path';
import { fileURLToPath } from 'url';
import { build as tsup } from 'tsup';

const __dirname = dirname(fileURLToPath(import.meta.url));
const pkg = JSON.parse(readFileSync(join(__dirname, 'package.json'), 'utf8'));

await tsup({
entry: [join(__dirname, 'example.mjs')],
entry: [join(__dirname, 'example.mjs').split(sep).join('/')],
outDir: join(__dirname, 'dist'),
target: 'node22',
format: ['esm'],
Expand Down
15 changes: 14 additions & 1 deletion packages/web/app/src/components/target/history/errors-and-changes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
Accordion,
AccordionContent,
AccordionHeader,
AccordionItem,
AccordionItem,2
AccordionTrigger,
} from '@/components/ui/accordion';
import { Button } from '@/components/ui/button';
Expand Down Expand Up @@ -79,6 +79,7 @@ const ChangesBlock_SchemaChangeWithUsageFragment = graphql(`
message(withSafeBasedOnUsageNote: false)
severityLevel
severityReason
criticalityReason
approval {
...ChangesBlock_SchemaChangeApprovalFragment
}
Expand Down Expand Up @@ -128,6 +129,8 @@ export const ChangesBlock_SchemaChangeFragment = graphql(`
message(withSafeBasedOnUsageNote: false)
severityLevel
severityReason
criticalityReason

approval {
...ChangesBlock_SchemaChangeApprovalFragment
}
Expand Down Expand Up @@ -243,6 +246,16 @@ function ChangeItem(
<CheckIcon className="inline size-3" /> Safe based on usage data
</span>
)}
{change.isSafeBasedOnUsage && change.criticalityReason && (
<span className="text-xs text-muted-foreground ml-1">
({change.criticalityReason})
</span>
)}





Comment on lines +249 to +258

@gemini-code-assist gemini-code-assist Bot Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Clean up the indentation of the closing </span> tag and remove the unnecessary empty lines/whitespace added within the JSX block to keep the code clean and maintainable.

Suggested change
{change.isSafeBasedOnUsage && change.criticalityReason && (
<span className="text-xs text-muted-foreground ml-1">
({change.criticalityReason})
</span>
)}
{change.isSafeBasedOnUsage && change.criticalityReason && (
<span className="text-xs text-muted-foreground ml-1">
({change.criticalityReason})
</span>
)}

{'usageStatistics' in change && change.usageStatistics && (
<>
{' '}
Expand Down
3 changes: 2 additions & 1 deletion packages/web/app/src/server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
import Fastify from 'fastify';
import cors from '@fastify/cors';
import FastifyStatic from '@fastify/static';
Expand All @@ -7,7 +8,7 @@ import { connectGithub } from './github';
import { connectLab } from './lab';
import { connectSlack } from './slack';

const __dirname = new URL('.', import.meta.url).pathname;
const __dirname = fileURLToPath(new URL('.', import.meta.url));
/**
* Whether the server is running in development mode.
* See the ./dev.ts file
Expand Down
9 changes: 5 additions & 4 deletions packages/web/app/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { resolve } from 'node:path';
import { resolve, sep } from 'node:path';
import { fileURLToPath } from 'node:url';
import type { Plugin, UserConfig } from 'vite';
import monacoEditor from 'vite-plugin-monaco-editor';
import tsconfigPaths from 'vite-tsconfig-paths';
Expand All @@ -7,7 +8,7 @@ import { sentryVitePlugin } from '@sentry/vite-plugin';
import tailwindcss from '@tailwindcss/vite';
import react from '@vitejs/plugin-react';

const __dirname = new URL('.', import.meta.url).pathname;
const __dirname = fileURLToPath(new URL('.', import.meta.url));

// Add react-scan in local development mode
const reactScanPlugin: Plugin = {
Expand Down Expand Up @@ -52,8 +53,8 @@ export default {
outDir: 'dist',
rollupOptions: {
input: {
index: resolve(__dirname, 'index.html'),
['preflight-worker-embed']: resolve(__dirname, 'preflight-worker-embed.html'),
index: resolve(__dirname, 'index.html').split(sep).join('/'),
['preflight-worker-embed']: resolve(__dirname, 'preflight-worker-embed.html').split(sep).join('/'),
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion scripts/runify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ async function compile(

await tsup({
entryPoints: (Array.isArray(entryPoint) ? entryPoint : [entryPoint]).map(entryPoint =>
normalize(join(cwd, entryPoint)),
normalize(join(cwd, entryPoint)).split(sep).join('/'),
),
outDir: out,
target: 'node22',
Expand Down