Skip to content

chore(release): switch to npm trusted publishing#310

Merged
dotansimha merged 5 commits into
mainfrom
fix-releaes-pipeline
Jul 16, 2026
Merged

chore(release): switch to npm trusted publishing#310
dotansimha merged 5 commits into
mainfrom
fix-releaes-pipeline

Conversation

@dotansimha

@dotansimha dotansimha commented Jul 16, 2026

Copy link
Copy Markdown
Member
  • stable
  • rc
  • alpha/snapshot
  • unify into a single file
  • configure npm trusted publishing
  • test in ci

@dotansimha
dotansimha requested review from jdolle and n1ru4l July 16, 2026 15:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the pnpm build step from the release script in package.json. The reviewer raised a valid concern that this could lead to publishing stale or unbuilt artifacts when run locally or in other environments, and suggested keeping the build step in the script while configuring the CI workflow to invoke the publish command directly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread package.json Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/federation-composition 0.23.1-alpha-20260716152057-ffbdb6d404fed874b65c8e550f57e5909c7d1321 npm ↗︎ unpkg ↗︎

@jdolle jdolle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Comment thread .github/workflows/release.yaml
@dotansimha
dotansimha merged commit 7ea12fb into main Jul 16, 2026
5 checks passed
@dotansimha
dotansimha deleted the fix-releaes-pipeline branch July 16, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants