create 17.x.x branch rebased on 16.x.x

.babelrc-npm.json

@@ -1,27 +1,10 @@
 {
+  "presets": [
+    ["@babel/preset-env", { "modules": false, "targets": { "node": "14" } }]
+  ],
   "plugins": [
+    ["./resources/add-extension-to-import-paths.js", { "extension": "js" }],
     "@babel/plugin-transform-typescript",
-    "./resources/inline-invariant"
-  ],
-  "env": {
-    "cjs": {
-      "presets": [
-        [
-          "@babel/preset-env",
-          { "modules": "commonjs", "targets": { "node": "12" } }
-        ]
-      ],
-      "plugins": [
-        ["./resources/add-extension-to-import-paths", { "extension": "js" }]
-      ]
-    },
-    "mjs": {
-      "presets": [
-        ["@babel/preset-env", { "modules": false, "targets": { "node": "12" } }]
-      ],
-      "plugins": [
-        ["./resources/add-extension-to-import-paths", { "extension": "mjs" }]
-      ]
-    }
-  }
+    "./resources/inline-invariant.js"
+  ]
 }

.c8rc.json

@@ -7,15 +7,13 @@
     "src/jsutils/Maybe.ts",
     "src/jsutils/ObjMap.ts",
     "src/jsutils/PromiseOrValue.ts",
-    "src/utilities/assertValidName.ts",
     "src/utilities/typedQueryDocumentNode.ts",
     "src/**/__tests__/**/*.ts"
   ],
   "clean": true,
-  "temp-directory": "coverage",
-  "report-dir": "coverage",
+  "report-dir": "reports/coverage",
   "skip-full": true,
-  "reporter": ["json", "html", "text"],
+  "reporter": ["html", "text"],
   "check-coverage": true,
   "branches": 100,
   "lines": 100,

.eslintignore

@@ -1,7 +1,8 @@
 # Copied from '.gitignore', please keep it in sync.
 /.eslintcache
+/.stryker-tmp
 /node_modules
-/coverage
+/reports
 /npmDist
 /denoDist
 /websiteDist

.eslintrc.yml

@@ -2,6 +2,7 @@ parserOptions:
   sourceType: script
 env:
   es2022: true
+  shared-node-browser: true
 reportUnusedDisableDirectives: true
 plugins:
   - internal-rules
@@ -10,7 +11,10 @@ plugins:
   - simple-import-sort
 settings:
   node:
-    tryExtensions: ['.js', '.jsx', '.json', '.node', '.ts', '.d.ts']
+    tryExtensions: ['.js', '.ts', '.jsx', '.json', '.node', '.d.ts']
+  # eslint-plugin-import tries to parse all imported files included huge ones (e.g. 'typescript')
+  # that leads to very poor perfomance so to fix that we disable all checks on external files.
+  import/ignore: ['node_modules']
 
 rules:
   ##############################################################################
@@ -34,7 +38,7 @@ rules:
   node/no-exports-assign: error
   node/no-extraneous-import: error
   node/no-extraneous-require: error
-  node/no-missing-import: error
+  node/no-missing-import: [error, { allowModules: ['graphql'] }]
   node/no-missing-require: error
   node/no-new-require: error
   node/no-path-concat: error
@@ -80,7 +84,7 @@ rules:
 
   # Static analysis
   # https://github.com/benmosher/eslint-plugin-import#static-analysis
-  import/no-unresolved: error
+  import/no-unresolved: [error, { ignore: ['graphql'] }]
   import/named: error
   import/default: error
   import/namespace: error
@@ -146,6 +150,9 @@ rules:
   simple-import-sort/imports:
     - error
     - groups:
+        # Node.js builtin modules
+        - ["^node:\\w"]
+
         # Packages.
         # Things that start with a letter (or digit or underscore), or `@` followed by a letter.
         - ["^@?\\w"]
@@ -172,7 +179,7 @@ rules:
   simple-import-sort/exports: off # TODO
 
   ##############################################################################
-  # ESLint builtin rules list based on `v8.13.x`
+  # ESLint builtin rules list based on `v8.21.x`
   ##############################################################################
 
   # Possible Errors
@@ -184,6 +191,7 @@ rules:
   no-await-in-loop: error
   no-compare-neg-zero: error
   no-cond-assign: error
+  no-constant-binary-expression: error
   no-console: warn
   no-constant-condition: error
   no-control-regex: error
@@ -340,7 +348,7 @@ rules:
   max-lines: off
   max-lines-per-function: off
   max-nested-callbacks: off
-  max-params: off
+  max-params: [error, 5] # TODO: drop to default number, which is 3
   max-statements: off
   max-statements-per-line: off
   multiline-comment-style: off
@@ -487,7 +495,7 @@ overrides:
       tsdoc/syntax: error
 
       ##########################################################################
-      # `@typescript-eslint/eslint-plugin` rule list based on `v5.19.x`
+      # `@typescript-eslint/eslint-plugin` rule list based on `v5.33.x`
       ##########################################################################
 
       # Supported Rules
@@ -499,6 +507,7 @@ overrides:
       '@typescript-eslint/ban-tslint-comment': error
       '@typescript-eslint/ban-types': off # TODO temporarily disabled
       '@typescript-eslint/class-literal-property-style': off # TODO enable after TS conversion
+      '@typescript-eslint/consistent-generic-constructors': error
       '@typescript-eslint/consistent-indexed-object-style':
         [error, index-signature]
       '@typescript-eslint/consistent-type-assertions': off # TODO temporarily disable
@@ -514,6 +523,7 @@ overrides:
       '@typescript-eslint/no-base-to-string': error
       '@typescript-eslint/no-confusing-non-null-assertion': error
       '@typescript-eslint/no-confusing-void-expression': off # TODO enable with ignoreArrowShorthand
+      '@typescript-eslint/no-duplicate-enum-values': error
       '@typescript-eslint/no-dynamic-delete': off
       '@typescript-eslint/no-empty-interface': error
       '@typescript-eslint/no-explicit-any': off # TODO error
@@ -531,7 +541,6 @@ overrides:
       '@typescript-eslint/no-non-null-asserted-nullish-coalescing': error
       '@typescript-eslint/no-non-null-asserted-optional-chain': error
       '@typescript-eslint/no-non-null-assertion': error
-      '@typescript-eslint/no-parameter-properties': error
       '@typescript-eslint/no-redundant-type-constituents': error
       '@typescript-eslint/no-invalid-void-type': error
       '@typescript-eslint/no-require-imports': error
@@ -551,6 +560,7 @@ overrides:
       '@typescript-eslint/no-useless-empty-export': error
       '@typescript-eslint/no-var-requires': error
       '@typescript-eslint/non-nullable-type-assertion-style': off #TODO temporarily disabled
+      '@typescript-eslint/parameter-properties': error
       '@typescript-eslint/prefer-as-const': error
       '@typescript-eslint/prefer-enum-initializers': error
       '@typescript-eslint/prefer-for-of': error
@@ -668,40 +678,44 @@ overrides:
       node: true
     rules:
       node/no-sync: off
-      node/no-unpublished-require: [error, { allowModules: ['mocha'] }]
+      node/no-unpublished-import: [error, { allowModules: ['mocha'] }]
       import/no-extraneous-dependencies: [error, { devDependencies: true }]
+      import/no-namespace: off
       import/no-nodejs-modules: off
   - files: 'integrationTests/*/**'
+    parserOptions:
+      sourceType: module
     env:
       node: true
     rules:
       node/no-sync: off
-      node/no-missing-require: [error, { allowModules: ['graphql'] }]
-      import/no-commonjs: off
       import/no-nodejs-modules: off
       no-console: off
   - files: 'benchmark/**'
+    parserOptions:
+      sourceType: module
     env:
       node: true
     rules:
-      internal-rules/only-ascii: [error, { allowEmoji: true }]
       node/no-sync: off
-      node/no-missing-require: off
+      import/no-unresolved: off
       import/no-nodejs-modules: off
-      import/no-commonjs: off
-      no-console: off
-      no-await-in-loop: off
   - files: 'resources/**'
     env:
       node: true
     rules:
       internal-rules/only-ascii: [error, { allowEmoji: true }]
-      node/no-unpublished-require: off
+      node/no-unpublished-import: off
       node/no-sync: off
+      import/no-namespace: off
       import/no-extraneous-dependencies: [error, { devDependencies: true }]
       import/no-nodejs-modules: off
-      import/no-commonjs: off
       no-console: off
+  - files: 'resources/eslint-internal-rules/**'
+    env:
+      node: true
+    rules:
+      import/no-commonjs: off
   - files: '**/*.jsx'
     parserOptions:
       sourceType: module

.github/workflows/ci.yml

@@ -1,9 +1,5 @@
 name: CI
-on:
-  workflow_call:
-    secrets:
-      codecov_token:
-        required: true
+on: workflow_call
 permissions: {}
 jobs:
   lint:
@@ -144,41 +140,12 @@ jobs:
       - name: Run Tests
         run: npm run fuzzonly
 
-  coverage:
-    name: Measure test coverage
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repo
-        uses: actions/checkout@v4
-        with:
-          persist-credentials: false
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          cache: npm
-          node-version-file: '.node-version'
-
-      - name: Install Dependencies
-        run: npm ci --ignore-scripts
-
-      - name: Run tests and measure code coverage
-        run: npm run testonly:cover
-
-      - name: Upload coverage to Codecov
-        if: ${{ always() }}
-        uses: codecov/codecov-action@v4
-        with:
-          file: ./coverage/coverage-final.json
-          fail_ci_if_error: true
-          token: ${{ secrets.codecov_token }}
-
   test:
     name: Run tests on Node v${{ matrix.node_version_to_setup }}
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node_version_to_setup: [12, 14, 16, 17]
+        node_version_to_setup: [14, 16, 18]
     permissions:
       contents: read # for actions/checkout
     steps:
@@ -196,8 +163,8 @@ jobs:
       - name: Install Dependencies
         run: npm ci --ignore-scripts
 
-      - name: Run Tests
-        run: npm run testonly
+      - name: Run Tests with coverage
+        run: npm run testonly:cover
 
   codeql:
     name: Run CodeQL security scan
@@ -222,7 +189,6 @@ jobs:
   build-npm-dist:
     name: Build 'npmDist' artifact
     runs-on: ubuntu-latest
-    needs: [test, fuzz, lint, integrationTests]
     permissions:
       contents: read # for actions/checkout
     steps:
@@ -252,7 +218,6 @@ jobs:
   build-deno-dist:
     name: Build 'denoDist' artifact
     runs-on: ubuntu-latest
-    needs: [test, fuzz, lint, integrationTests]
     permissions:
       contents: read # for actions/checkout
     steps:

.github/workflows/mutation-testing.yml

@@ -0,0 +1,32 @@
+name: Mutation Testing
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: '0 0 * * *' # run once every day at 00:00 UTC
+jobs:
+  lint:
+    name: Run mutation testing
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
+        with:
+          cache: npm
+          node-version-file: '.node-version'
+
+      - name: Install Dependencies
+        run: npm ci --ignore-scripts
+
+      - name: Run mutation testing
+        run: npm run testonly:mutate
+
+      - name: Upload mutation testing report
+        uses: actions/upload-artifact@v3
+        with:
+          name: mutationTestingReport
+          path: ./reports/mutation/mutation.html

.github/workflows/pull_request.yml

@@ -7,8 +7,6 @@ jobs:
       contents: read # for actions/checkout
       security-events: write # for codeql-action
     uses: ./.github/workflows/ci.yml
-    secrets:
-      codecov_token: ${{ secrets.CODECOV_TOKEN }}
 
   dependency-review:
     name: Security check of added dependencies
@@ -50,11 +48,11 @@ jobs:
         run: npm ci --ignore-scripts
 
       - name: Generate report
-        run: 'node resources/diff-npm-package.js BASE HEAD'
+        run: 'npm run diff:npm BASE HEAD'
 
       - name: Upload generated report
         uses: actions/upload-artifact@v4
         with:
           name: npm-dist-diff.html
-          path: ./npm-dist-diff.html
+          path: ./reports/npm-dist-diff.html
           if-no-files-found: ignore

.github/workflows/push.yml

@@ -7,8 +7,6 @@ jobs:
       contents: read # for actions/checkout
       security-events: write
     uses: ./.github/workflows/ci.yml
-    secrets:
-      codecov_token: ${{ secrets.CODECOV_TOKEN }}
   deploy-to-npm-branch:
     name: Deploy to `npm` branch
     needs: ci

.gitignore

@@ -8,8 +8,9 @@
 /diff-npm-package.html
 /.eslintcache
 /.cspellcache
+/.stryker-tmp
 node_modules
-/coverage
+/reports
 /npmDist
 /denoDist
 /websiteDist

.mocharc.yml

@@ -2,6 +2,6 @@ fail-zero: true
 throw-deprecation: true
 check-leaks: true
 require:
-  - 'resources/ts-register.js'
+  - 'ts-node/register/transpile-only'
 extension:
   - 'ts'

.node-version

@@ -1 +1 @@
-v17
+v18