Skip to content

internal: remove version/preversion scripts #4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaacovCR merged 1 commit into from
Feb 27, 2026
Merged

internal: remove version/preversion scripts #4603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@
"node": "^20.0.0 || ^22.0.0 || ^24.0.0 || >=25.0.0"
},
"scripts": {
"preversion": "bash -c '. ./resources/checkgit.sh && npm ci --ignore-scripts'",
"version": "node --import ./resources/register-ts-node.js resources/gen-version.ts && npm test && git add src/version.ts",
"fuzzonly": "mocha --full-trace src/**/__tests__/**/*-fuzz.ts",
"changelog": "node --import ./resources/register-ts-node.js resources/gen-changelog.ts",
"release:prepare": "node --import ./resources/register-ts-node.js resources/release-prepare.ts",
Expand Down
39 changes: 0 additions & 39 deletions resources/checkgit.sh
View file
Open in desktop

This file was deleted.

24 changes: 23 additions & 1 deletion resources/release-prepare.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,24 @@ try {
process.exit(1);
}

console.log('Running npm version without creating a tag...');
console.log('Installing dependencies...');
npm().ci('--ignore-scripts');

console.log('Bumping package version without creating a tag...');
npm().version(...args.npmVersionArgs, '--no-git-tag-version');

console.log('Updating src/version.ts...');
npm().exec(
'--',
'node',
'--import',
'./resources/register-ts-node.js',
'resources/gen-version.ts',
);

console.log('Running test suite...');
npm().run('test');

const { version } = readPackageJSON();
console.log(`Generating changelog for v${version}...`);
const changelogArgs = ['--silent', 'changelog'];
Expand Down Expand Up @@ -97,6 +112,13 @@ function validateBranchState(releaseBranch: string): void {
'Working directory must be clean before running release:prepare.',
);
}
const branchStatus = git().status('--porcelain', '--branch');
const branchSummary = branchStatus.split('\n')[0] ?? '';
if (/\[[^\]]+\]/.test(branchSummary)) {
throw new Error(
`Current branch "${checkedBranch}" is not up to date with its upstream.`,
);
}

let releaseBranchHead: string;
try {
Expand Down
Loading