Skip to content

fix(changelog): adjust end-ref to not skip last PR #4604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaacovCR merged 1 commit into from
Feb 27, 2026
Merged

fix(changelog): adjust end-ref to not skip last PR #4604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions resources/gen-changelog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,17 +73,29 @@ function parseFromRevArg(rawArgs: ReadonlyArray<string>): string | null {
async function genChangeLog(): Promise<string> {
const { version } = packageJSON;
const releaseTag = `v${version}`;
const fromRev = parseFromRevArg(process.argv.slice(2));
const releaseTagExists = git().tagExists(releaseTag);
const tag = releaseTagExists ? null : releaseTag;
let baseRef = parseFromRevArg(process.argv.slice(2));

let tag: string | null;
let baseRef: string;
let endRef: string;
if (releaseTagExists) {
baseRef ??= releaseTag;
} else if (baseRef == null) {
const parentPackageJSON = git().catFile('blob', 'HEAD~1:package.json');
const parentVersion = JSON.parse(parentPackageJSON).version;
baseRef = `v${parentVersion}`;
tag = null;
baseRef = fromRev ?? releaseTag;
endRef = 'HEAD';
} else {
tag = releaseTag;
if (fromRev != null) {
baseRef = fromRev;
} else {
const parentPackageJSON = git().catFile('blob', 'HEAD~1:package.json');
const parentVersion = JSON.parse(parentPackageJSON).version;
baseRef = `v${parentVersion}`;
}
endRef = 'HEAD~1';
}
const commitsRange = releaseTagExists ? `${baseRef}..` : `${baseRef}..HEAD~1`;

const commitsRange = `${baseRef}..${endRef}`;
const commitsList = git().revList('--reverse', commitsRange);

const allPRs = await getPRsInfo(commitsList);
Expand Down
Loading