feat!: update ts version and build cjs and esm separatelly#28
Merged
Conversation
Reviewer's GuideThis pull request updates the TypeScript version to ^5.8.3 and refactors the build process using Gulp to generate separate CommonJS (CJS) and ECMAScript Module (ESM) builds. It modifies File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @Qbit982 - I've reviewed your changes - here's some feedback:
- Consider removing or clarifying the purpose of the top-level
mainandtypesfields, as theexportsfield now defines the primary entry points. - The new Gulp build adds complexity; evaluate if invoking
tscdirectly with configuration overrides could achieve the same CJS/ESM outputs more simply.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
563428a to
7daa252
Compare
SeqviriouM
approved these changes
May 6, 2025
…nd migrate ts-jest to @swc/jest
7e6dade to
d7c0c43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update TypeScript Version and Build CJS/MJS Separately
Summary by Sourcery
Update project build configuration to support both CommonJS and ES modules with improved TypeScript setup
New Features:
Enhancements:
Build:
Chores: