Support -a command line arguments#10
Open
lateefj wants to merge 6 commits intogravityblast:masterfrom
Open
Conversation
For supporting and commandline arugment to pass to the binary there is a new '-a' option. Also my editor autoformats to gofmt so these files are cleaned up with the standarde format.
Owner
|
Hi guys, thank you for your work. I'm in the middle of a complete rewrite of fresh, and I would like to wait for that before merging this. can you please wait for some days (I hope :) ) so that I can finish it and we can prepare a similar PR for the new version? |
15 tasks
|
This will be useful! |
Author
|
Should I close this PR and create a new on based on the rewrite @pilu ? |
|
@pilu how's the rewrite coming along? If it's still really far away, any chance to get this merged in the meantime? Would really be keen to see this PR merged, since I'd like to use this feature. |
For supporting and commandline arugment to pass to the binary there is a new '-a' option. Also my editor autoformats to gofmt so these files are cleaned up with the standarde format.
For supporting and commandline arugment to pass to the binary there is a new '-a' option. Also my editor autoformats to gofmt so these files are cleaned up with the standarde format.
Author
|
@pilu I rebased a while back any status on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For supporting and commandline arugment to pass to the binary
there is a new '-a' option. Also my editor autoformats to
gofmt so these files are cleaned up with the standarde format.