Fix: use full aggregation labels map for Итого row#8
Merged
Conversation
Import aggregationLabels from types/pivot.ts instead of incomplete hardcoded map. Covers all aggregation types including int_sum, median, variance, etc. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoUse full aggregation labels map for total row
WalkthroughsDescription• Replace hardcoded aggregation labels with centralized map from types • Support all aggregation types including int_sum, median, variance • Add proper TypeScript typing for AggregationType • Improve maintainability by using single source of truth Diagramflowchart LR
A["Hardcoded labels<br/>in component"] -->|Replace with| B["aggregationLabels<br/>from types/pivot"]
B -->|Covers all types| C["int_sum, median,<br/>variance, etc."]
B -->|Adds typing| D["AggregationType<br/>type safety"]
File Changes1. frontend/src/components/PivotTable/PivotTable.tsx
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewⓘ The new review experience is currently in Beta. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import aggregationLabels from types/pivot.ts instead of incomplete hardcoded map. Covers all aggregation types including int_sum, median, variance, etc.