Skip to content

Use TypeScript and adapt to changed override API#5366

Merged
greenbonebot merged 3 commits into
mainfrom
typescript-overrides
Jun 24, 2026
Merged

Use TypeScript and adapt to changed override API#5366
greenbonebot merged 3 commits into
mainfrom
typescript-overrides

Conversation

@bjoernricks

Copy link
Copy Markdown
Contributor

What

Use TypeScript and adapt to changed override API

Why

Use TypeScript for the changed code, use camelCase for all parameters,
properties and arguments, add unit tests and adapt to new create and
save override API of gsad.

References

Requires greenbone/gsad#424
https://jira.greenbone.net/browse/GEA-1870

Checklist

  • [x ] Tests

@bjoernricks bjoernricks requested a review from a team as a code owner June 24, 2026 09:57
@greenbonebot greenbonebot enabled auto-merge (rebase) June 24, 2026 09:57
@github-actions

github-actions Bot commented Jun 24, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 532c93f.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Use TypeScript for the changed code, use camelCase for all parameters,
properties and arguments, add unit tests and adapt to new create and
save override API of gsad.
@bjoernricks bjoernricks force-pushed the typescript-overrides branch from 2aeefab to 532c93f Compare June 24, 2026 10:33
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.11321% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.23%. Comparing base (ad1bfc4) to head (532c93f).

Files with missing lines Patch % Lines
src/web/pages/overrides/OverrideComponent.tsx 98.19% 2 Missing ⚠️
src/web/pages/overrides/OverrideDialog.tsx 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5366      +/-   ##
==========================================
+ Coverage   79.78%   80.23%   +0.45%     
==========================================
  Files        1262     1263       +1     
  Lines       33175    33168       -7     
  Branches     9941     9934       -7     
==========================================
+ Hits        26470    26614     +144     
+ Misses       5982     5848     -134     
+ Partials      723      706      -17     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greenbonebot greenbonebot merged commit a18549a into main Jun 24, 2026
27 checks passed
@greenbonebot greenbonebot deleted the typescript-overrides branch June 24, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants