Use TypeScript and adapt to changed override API#5366
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Use TypeScript for the changed code, use camelCase for all parameters, properties and arguments, add unit tests and adapt to new create and save override API of gsad.
2aeefab to
532c93f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5366 +/- ##
==========================================
+ Coverage 79.78% 80.23% +0.45%
==========================================
Files 1262 1263 +1
Lines 33175 33168 -7
Branches 9941 9934 -7
==========================================
+ Hits 26470 26614 +144
+ Misses 5982 5848 -134
+ Partials 723 706 -17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ozgen
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Use TypeScript and adapt to changed override API
Why
Use TypeScript for the changed code, use camelCase for all parameters,
properties and arguments, add unit tests and adapt to new create and
save override API of gsad.
References
Requires greenbone/gsad#424
https://jira.greenbone.net/browse/GEA-1870
Checklist