Fix getting the existing tags when creating a new tag#5393
Merged
Conversation
When opening the create tag dialog for multiple entities from the button of the list page tables the list of existing tags was not loaded correctly. For loading the corresponding list of tags to the current entity type of the page it is required to use the resource type and not the api type. API type converts for example host to asset.
Ensure it is possible to create a tag for multiple entities.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5393 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 1266 1266
Lines 33078 33078
Branches 9917 9917
=======================================
Hits 26642 26642
Misses 5746 5746
Partials 690 690 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a-h-abdelsalam
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix getting the existing tags when creating a new tag
Why
When opening the create tag dialog for multiple entities from the button of the list page tables the list of existing tags was not loaded correctly. For loading the corresponding list of tags to the current entity type of the page it is required to use the resource type and not the api type. API type converts for example host to asset.
References
https://jira.greenbone.net/browse/GEA-1690
Checklist