Skip to content

Allow Filter instances for ReportCommand params too#5397

Open
bjoernricks wants to merge 1 commit into
mainfrom
report-command-filter-params
Open

Allow Filter instances for ReportCommand params too#5397
bjoernricks wants to merge 1 commit into
mainfrom
report-command-filter-params

Conversation

@bjoernricks

Copy link
Copy Markdown
Contributor

What

Allow Filter instances for ReportCommand params too

Why

Passing a Filter instance besides a filter string is possible to for all filter params in the ReportCommand.

@bjoernricks bjoernricks requested a review from a team as a code owner July 2, 2026 09:06
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 4a3d65f.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

@greenbonebot greenbonebot enabled auto-merge (rebase) July 2, 2026 09:06
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.61%. Comparing base (7f98d70) to head (4a3d65f).

Files with missing lines Patch % Lines
src/gmp/commands/report.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5397   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files        1269     1269           
  Lines       33075    33075           
  Branches     9921     9921           
=======================================
  Hits        26663    26663           
  Misses       5723     5723           
  Partials      689      689           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Passing a Filter instance besides a filter string is possible to for all
filter params in the ReportCommand.
@bjoernricks bjoernricks force-pushed the report-command-filter-params branch from 290378c to 4a3d65f Compare July 2, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant