Fix Delta Reports#5400
Open
bjoernricks wants to merge 2 commits into
Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Use consistent naming for delta report components, convert to TypeScript and adapt types. Don't load the delta results via `<get_results/>` and instead use the results from the report report. It's not possible to get deltas via `<get_results/>`.
Re-introduce the parsing of the report report results which contain the results with delta information required to display the delta. Using the results from `<get_results/>` doesn't work for delta results because the delta information is not available.
bjoernricks
force-pushed
the
fix-delta-reports
branch
from
5585465 to
a06651d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5400 +/- ##
==========================================
+ Coverage 80.62% 80.63% +0.01%
==========================================
Files 1268 1268
Lines 33063 33086 +23
Branches 9921 9937 +16
==========================================
+ Hits 26656 26678 +22
Misses 5718 5718
- Partials 689 690 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ozgen
approved these changes
Jul 3, 2026
|
|
||
| return new CollectionCounts({ | ||
| first: resultsElement._start, | ||
| rows: resultCountElement?.filtered, |
Member
There was a problem hiding this comment.
Should rows use resultsElement._max here?
rows is the page size, while filtered is the total number of matching results. Using filtered may cause the Previous button to stay disabled on later pages.
Suggested change
| rows: resultCountElement?.filtered, | |
| rows: resultsElement._max, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix Delta Reports
Parse and use the results from the
<get_report/>response again for delta reports. This was removed while refactoring the report details for the multi requests.Why
Loading the results via
<get_results/>doesn't work for delta reports. The returned data doesn't contain the delta information and won't display the expected data.References
https://jira.greenbone.net/browse/GEA-1903
https://jira.greenbone.net/browse/GEA-1856
https://jira.greenbone.net/browse/GEA-1904
https://jira.greenbone.net/browse/GEA-1906
Checklist