Add: Add support for WAS scanner preferences.#425
Open
a-h-abdelsalam wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 95.09% 95.10% +0.01%
==========================================
Files 32 32
Lines 5075 5092 +17
Branches 144 144
==========================================
+ Hits 4826 4843 +17
Misses 180 180
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
a-h-abdelsalam
force-pushed
the
support-scanner-preferences-in-was-tasks
branch
from
78fb76e to
59b6810
Compare
mattmundell
reviewed
Jun 26, 2026
| param->value ? param->value : ""); | ||
| } | ||
|
|
||
| CHECK_VARIABLE_INVALID (scan_mode, "Create Web Application Task"); |
Contributor
There was a problem hiding this comment.
There's an error return in here, which leaks schedule_element etc.
Maybe move up to the other CHECK_VARIABLE_INVALIDS?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add support for WAS scanner preferences when creating or modifying web scanner tasks.
Why
Web application scanner now supports preferences.
References
GEA-1872