Skip to content

Add group-wise miQC modeling for multimodal mitochondrial fractions - #18

Draft
cgreene with Copilot wants to merge 2 commits into
mainfrom
copilot/multimodal-mtrna-filter-cells
Draft

Add group-wise miQC modeling for multimodal mitochondrial fractions#18
cgreene with Copilot wants to merge 2 commits into
mainfrom
copilot/multimodal-mtrna-filter-cells

Conversation

Copilot AI commented May 27, 2026

Copy link
Copy Markdown

miQC previously fit one global 2-component mixture, which can misclassify cells when datasets contain biologically distinct cell types with different baseline %mtRNA. This update introduces optional group-wise modeling/filtering so posterior-based QC is applied within relevant subpopulations.

  • Modeling: optional per-group fits

    • Added group to mixtureModel().
    • When group is set to a colData(sce) column, miQC fits one model per group and returns a named grouped model object.
    • Default behavior is unchanged (group = NULL uses a single global model).
  • Filtering: optional per-group posterior decisions

    • Added group to filterCells().
    • Supports grouped models from mixtureModel(..., group=...) and applies posterior cutoff + boundary rules independently per group before recombining kept cells.
    • Added validation for missing/invalid group columns and mismatched model/group usage.
  • Documentation updates

    • Updated mixtureModel and filterCells Rd docs for new group parameter and grouped return behavior.
    • Added vignette section showing recommended usage for mixed cell populations with different baseline mitochondrial fractions.
    • Added NEWS entry describing group-wise support.
# Apply miQC within annotated cell-type strata
model_by_type <- mixtureModel(sce, group = "cell_type")
sce <- filterCells(sce, model = model_by_type, group = "cell_type")

Copilot AI linked an issue May 27, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Implement multimodal mtRNA filtering for cell types Add group-wise miQC modeling for multimodal mitochondrial fractions May 27, 2026
Copilot AI requested a review from cgreene May 27, 2026 14:40
Comment thread NEWS
+ Updated citation
Changes in version 1.7.1 (2023-01-04)
+ Added new function, get1DCutoff
+ Added optional group-wise modeling/filtering support to handle mixed cell populations with different baseline mitochondrial fractions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be a new version, not an additional bullet point in 1.7.1. Can you position it this way?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casey,
Thank you.
Please excuse my ignorance of github.
How do I get the script that does the multimodal analysis?

Thanks and best wishes,
Rich

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Rich,

If you are not a heavy github user this might be tough. What you are looking to do is clone the pull request's branch locally. The information on the branch is above (copilot/multimodal-mtrna-filter-cells) but you probably would need to be reasonably experienced with github to navigate this in practice (or an aggressive googler ;)).

Thanks!
Casey

@Rfriedmancolumbia

Rfriedmancolumbia commented May 27, 2026 via email

Copy link
Copy Markdown

@Rfriedmancolumbia

Rfriedmancolumbia commented May 28, 2026 via email

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multimodal %mtRNA of cell types

3 participants