Modernize tic-tac-toe contract to Move V2 syntax#15
Open
iskysun96 wants to merge 1 commit intogregnazario:mainfrom
Open
Modernize tic-tac-toe contract to Move V2 syntax#15iskysun96 wants to merge 1 commit intogregnazario:mainfrom
iskysun96 wants to merge 1 commit intogregnazario:mainfrom
Conversation
- Convert while loops with counters to for-range loops (T1-09) - Replace vector::borrow/borrow_mut with index notation (T1-01/T1-02) - Replace vector::push_back/length with receiver style (T1-03) - Replace simple_map:: calls with receiver style (T1-03) - Remove unnecessary acquires on inline functions - Add test suite with 27 tests covering happy paths and error cases - Fix Move.toml: pin AptosFramework to mainnet rev, add dev-addresses Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for aptos-tic-tac-toe canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vector::borrow/borrow_mutwith index notationvector::push_back/lengthandsimple_map::calls with receiver styleacquireson inline functionsmainnetrev, add dev-addressesTest plan
aptos move test)🤖 Generated with Claude Code