Replace sort 'buttons' with spans#1477
Open
TheWerbinator wants to merge 1 commit intogrid-js:masterfrom
Open
Conversation
The interactive part of sorting is the entire heading, but by using the 'button' tag for the sort direction arrows indicates to screen readers that the arrows themselves are the interactive content. Not only is this bad practice, but the arrows we are using in Grid.js are below the minimum size requirements for WCAG standard 2.5.8 - 24x24 pixels. By changing the indicators from buttons to spans, we stick to the best practice and avoid the WCAG violation with miniscule changes to the code and no conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Grid.js, the interactive part of sorting is the entire column heading; however, using the 'button' tag for the sort direction arrows indicates to screen readers that the arrows are the interactive content. Not only is this bad practice, but the arrow elements we use in Grid.js are below the minimum size requirements of WCAG standard 2.5.8 for interactive elements - 24x24 pixels. By changing the indicators from buttons to spans, we stick to the best practice and avoid the WCAG violation with minuscule changes to the code and no conflicts.