feat: introduce serial link recovery#123
Open
sansmoraxz wants to merge 26 commits intogrid-x:masterfrom
Open
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
alexjoedt
reviewed
Mar 23, 2026
Contributor
alexjoedt
left a comment
alexjoedt
left a comment
There was a problem hiding this comment.
Hey, sorry for the late review! Really like the direction here.
I left a few comments, mostly around defaults and some small robustness things. Hope they're helpful, let me know what you think!
Contributor
Author
|
Also this has the unexpected surprise of writing to currently open terminals. Lines 12 to 16 in 79617db IMO instead of pts terminals perhaps better to have some tmp file that's auto trapped and deleted once tests are run. |
alexjoedt
reviewed
Apr 8, 2026
alexjoedt
reviewed
Apr 17, 2026
alexjoedt
approved these changes
May 6, 2026
Contributor
alexjoedt
left a comment
alexjoedt
left a comment
There was a problem hiding this comment.
Sorry for the long review cycle, and thanks for your patience and the great contribution, @sansmoraxz!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt protection against shoddy wires in RTU connection.
Fixes: #122