Open
Conversation
Signed-off-by: Romeo Kienzler <romeo.kienzler1@ibm.com>
Signed-off-by: Romeo Kienzler <romeo.kienzler1@ibm.com>
Signed-off-by: Romeo Kienzler <romeo.kienzler1@ibm.com>
Signed-off-by: Romeo Kienzler <romeo.kienzler1@ibm.com>
romeokienzler
force-pushed
the
add_tests
branch
from
80611a9 to
e1e8ae1
Compare
albanpuech
reviewed
Mar 14, 2026
albanpuech
reviewed
Mar 18, 2026
| pip install -e . | ||
| ``` | ||
|
|
||
| ### PyTorch and torch-scatter (optional) |
Collaborator
There was a problem hiding this comment.
I dont think it is optional. the library doesnt work without torch scatter
Comment on lines
+193
to
+216
| ## Configuration Example | ||
|
|
||
| The base task uses the following configuration sections: | ||
|
|
||
| ```yaml | ||
| optimizer: | ||
| learning_rate: 0.001 | ||
| beta1: 0.9 | ||
| beta2: 0.999 | ||
| lr_decay: 0.7 | ||
| lr_patience: 5 | ||
|
|
||
| data: | ||
| networks: | ||
| - case14_ieee | ||
| - case118_ieee | ||
| ``` | ||
|
|
||
| ## Related | ||
|
|
||
| - [Reconstruction Task](reconstruction_task.md): Base class for reconstruction tasks | ||
| - [Power Flow Task](power_flow.md): Concrete implementation for power flow | ||
| - [Optimal Power Flow Task](optimal_power_flow.md): Concrete implementation for OPF | ||
| - [State Estimation Task](state_estimation.md): Concrete implementation for state estimation No newline at end of file |
Collaborator
There was a problem hiding this comment.
I would remove all of this.
Collaborator
There was a problem hiding this comment.
Why does this file go over each of the method and describes them instead of referencing them with ::: path:to:function? also, we dont need the configuration examples since we never use this class directly, but rather subclasses of this class
Collaborator
There was a problem hiding this comment.
Why does this file go over each of the method and describes them instead of referencing them with ::: path:to:function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.