Skip to content

perf(gen_build): memoize classpath-files for is-aoted? #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
english wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf(gen_build): memoize classpath-files for is-aoted? #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e84c2a
perf(gen_build): memoize classpath-files for is-aoted?
english Apr 4, 2026
22a7b97
perf(gen_build): pre-compute classpath file sets for is-aoted?
english Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/rules_clojure/gen_build.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,17 +256,17 @@
symbol)))))

(defn is-aoted?
[path ns]
[files-set ns]
(let [root-resource (#'clojure.core/root-resource ns)
class-file (str (.substring ^String root-resource 1) "__init.class")]
(some #(= class-file %) (classpath-files path))))
(contains? files-set class-file)))

(def special-namespaces '#{clojure.core clojure.core.specs.alpha})

(defn should-compile-namespace? [deps-bazel path ns]
(defn should-compile-namespace? [deps-bazel files-set ns]
(and (not (contains? special-namespaces ns))
(not (contains? (get-in deps-bazel [:no-aot]) ns))
(not (is-aoted? path ns))))
(not (is-aoted? files-set ns))))

(defn ns-matches-path?
[ns path]
Expand All @@ -282,16 +282,17 @@
:classpath
(map (fn [[path {:keys [lib-name]}]]
(when lib-name
{:clj (->> (find/find-namespaces [(fs/path->file path)] find/clj)
(map (fn [n]
[n (if (should-compile-namespace? deps-bazel path n)
(internal-dep-ns-aot-label lib-name n)
(library->label lib-name))]))
(into {}))
(let [files-set (set (classpath-files path))]
{:clj (->> (find/find-namespaces [(fs/path->file path)] find/clj)
(map (fn [n]
[n (if (should-compile-namespace? deps-bazel files-set n)
(internal-dep-ns-aot-label lib-name n)
(library->label lib-name))]))
(into {}))
:cljs (->> (find/find-namespaces [(fs/path->file path)] find/cljs)
(map (fn [n]
[n (library->label lib-name)]))
(into {}))})))
(into {}))}))))
(filter identity)
(apply merge-with merge)))

Expand Down Expand Up @@ -808,7 +809,8 @@
extra-args (-> deps-bazel
(get-in [:deps external-label]))
_ (assert (re-find #".jar$" (str jarpath)) "only know how to handle jars for now")
jarfile (JarFile. (fs/path->file jarpath))]
jarfile (JarFile. (fs/path->file jarpath))
files-set (set (jar-files jarpath))]
(vec
(concat
[(emit-bazel (list 'java_import (kwargs (merge-with into
Expand All @@ -828,7 +830,7 @@
ns-decl))))
(filter
(fn [ns-decl]
(should-compile-namespace? deps-bazel jarpath (parse/name-from-ns-decl ns-decl))))
(should-compile-namespace? deps-bazel files-set (parse/name-from-ns-decl ns-decl))))
(group-by parse/name-from-ns-decl)
(map (fn [[ns ns-decls]]
(let [extra-deps (-> deps-bazel (get-in [:deps (str deps-repo-tag "//:" (internal-dep-ns-aot-label lib ns))]))]
Expand Down