Skip to content

perf(gen_build): skip gen-dir when BUILD.bazel is newer than sources #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
english wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(gen_build): skip gen-dir when BUILD.bazel is newer than sources #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 58 additions & 47 deletions src/rules_clojure/gen_build.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,60 +660,71 @@
"given a source directory, write a BUILD.bazel for all .clj files in the directory. non-recursive"
[{:keys [deps-edn-dir] :as args} dir]
(assert (map? (:src-ns->label args)))
(let [paths (->> (fs/ls dir)
(let [entries (fs/ls dir)
paths (->> entries
(filter (fn [p]
(or (clj*-path? p)
(js-path? p))))
(sort-by str))
subdirs (->> dir
fs/ls
build-file (-> dir (fs/->path "BUILD.bazel") fs/path->file)
build-mtime (when (.exists build-file) (.lastModified build-file))
subdirs (->> entries
(filter (fn [^Path p]
(-> p .toFile fs/directory?)))
(sort-by str))
clj-subdirs (->>
subdirs
(filter (fn [p]
(some clj*-path? (seq (fs/ls-r p))))))
[has-binary? rules] (reduce (fn [[hb? acc] rule]
[(or hb? (= :clojure_binary (:type rule)))
(conj acc (emit-rule rule))])
[false []]
(->> paths
(group-by fs/basename)
(mapcat (fn [[_base paths]]
(ns-rules args paths)))))

content (str "#autogenerated, do not edit\n"
(emit-bazel (list 'package (kwargs {:default_visibility ["//visibility:public"]})))
"\n"
(emit-bazel (apply list 'load "@rules_clojure//:rules.bzl"
(cond-> ["clojure_library" "clojure_test"]
has-binary? (conj "clojure_binary"))))
"\n"
"\n"
(str/join "\n\n" rules)
"\n"
"\n"
(when (or (seq paths) (seq clj-subdirs))
(str
(emit-bazel (list 'clojure_library (kwargs {:name "__clj_lib"
:deps (vec
(concat
(dedupe (map (fn [p] (str ":" (fs/basename p))) paths))
(map (fn [p]
(str "//" (fs/path-relative-to deps-edn-dir p) ":__clj_lib")) clj-subdirs)))})))
"\n"
"\n"
(emit-bazel (list 'filegroup (kwargs (merge
{:name "__clj_files"
:srcs (mapv fs/filename paths)
:data (mapv (fn [p]
(str "//" (fs/path-relative-to deps-edn-dir p) ":__clj_files")) clj-subdirs)})))))))]
(let [build-file (-> dir (fs/->path "BUILD.bazel") fs/path->file)
changed? (not= content (when (.exists build-file) (slurp build-file :encoding "UTF-8")))]
(when changed?
(spit build-file content :encoding "UTF-8"))
{:files (count paths) :wrote (if changed? 1 0)})))
skip? (and build-mtime
(every? (fn [^Path p]
(<= (.lastModified (.toFile p)) ^long build-mtime))
paths)
(every? (fn [^Path p]
(let [child-build (-> p (fs/->path "BUILD.bazel") fs/path->file)]
(or (not (.exists child-build))
(<= (.lastModified child-build) ^long build-mtime))))
subdirs))]
(if skip?
{:files (count paths) :wrote 0}
(let [clj-subdirs (->>
subdirs
(filter (fn [p]
(some clj*-path? (seq (fs/ls-r p))))))
[has-binary? rules] (reduce (fn [[hb? acc] rule]
[(or hb? (= :clojure_binary (:type rule)))
(conj acc (emit-rule rule))])
[false []]
(->> paths
(group-by fs/basename)
(mapcat (fn [[_base paths]]
(ns-rules args paths)))))
content (str "#autogenerated, do not edit\n"
(emit-bazel (list 'package (kwargs {:default_visibility ["//visibility:public"]})))
"\n"
(emit-bazel (apply list 'load "@rules_clojure//:rules.bzl"
(cond-> ["clojure_library" "clojure_test"]
has-binary? (conj "clojure_binary"))))
"\n"
"\n"
(str/join "\n\n" rules)
"\n"
"\n"
(when (or (seq paths) (seq clj-subdirs))
(str
(emit-bazel (list 'clojure_library (kwargs {:name "__clj_lib"
:deps (vec
(concat
(dedupe (map (fn [p] (str ":" (fs/basename p))) paths))
(map (fn [p]
(str "//" (fs/path-relative-to deps-edn-dir p) ":__clj_lib")) clj-subdirs)))})))
"\n"
"\n"
(emit-bazel (list 'filegroup (kwargs (merge
{:name "__clj_files"
:srcs (mapv fs/filename paths)
:data (mapv (fn [p]
(str "//" (fs/path-relative-to deps-edn-dir p) ":__clj_files")) clj-subdirs)})))))))
changed? (not= content (when build-mtime (slurp build-file :encoding "UTF-8")))]
(when changed?
(spit build-file content :encoding "UTF-8"))
{:files (count paths) :wrote (if changed? 1 0)}))))

(s/fdef gen-source-paths- :args (s/cat :a (s/keys :req-un [::deps-edn-dir ::src-ns->label ::dep-ns->label ::jar->lib ::deps-repo-tag ::deps-bazel]) :paths (s/coll-of fs/path?)))
(defn gen-source-paths-
Expand Down