Breadcrumbs from root and everywhere#2
Closed
AZsSPC wants to merge 13 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the theme’s breadcrumb rendering and styling so breadcrumbs are always rendered from the root trail and visually styled as “chevrons”.
Changes:
- Simplifies the breadcrumbs Mustache template to iterate directly over
items(removes the extralistwrapper). - Updates the theme renderer to return a flat breadcrumb item array, and ensures the last breadcrumb is non-clickable.
- Revises breadcrumb and navigation styling (chevron look via
clip-path, alternating backgrounds, and removes some max-width constraints).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
templates/breadcrumbs.mustache |
Removes the outer list wrapper and renders a single <ol> using items. |
scss/standard.scss |
Adjusts breadcrumb styling (chevron shapes, alternation) and loosens navigation width constraints. |
classes/output/core_renderer.php |
Changes breadcrumb data shape, adds a “My courses” crumb for course-view pages, and passes items directly to the template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…, add layout properties
matasarei
force-pushed
the
Breadcrumbs-from-root-and-everywhere
branch
from
95b097a to
414bd40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.