Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
collindutter
approved these changes
Jul 13, 2026
cjkindel
enabled auto-merge
July 13, 2026 19:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Summary
Fixed issue #2241: LocalVectorStoreDriver.query_vector() leaking entries across namespaces sharing a hyphenated prefix.
Root cause: query_vector() filtered entries with a key-prefix check k.startswith(f"{namespace}-") against the derived storage key (f"{namespace}-{vector_id}"). Since namespaces can contain hyphens, a query for "foo" also matched entries in "foo-bar".
Fix in local_vector_store_driver.py:101: swapped the prefix check for the exact-match filter v.namespace == namespace, matching the semantics already used by the sibling load_entries() method.
Regression test added in test_local_vector_store_driver.py reproducing the issue's scenario ("foo" vs "foo-bar").
Both query_vector tests pass.
Issue ticket number and link
Closes #2241