Define set() only for Table and Column#15
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR narrows the public set() API so it’s only exposed on Table/table subclasses and Column/column subclasses, while moving the shared implementation into an internal Object._set_value() helper.
Changes:
- Removed
Object.set()as a public method and introduced internalObject._set_value()for shared value-setting logic. - Added
set()wrappers toTableandColumnthat delegate to_set_value(). - Added a new test case exercising
set()on anArraytable.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| testing/test_table.py | Adds a new test for calling set() on a table (Array). |
| grnpy/table.pyx | Adds Table.set() delegating to internal _set_value(). |
| grnpy/object.pyx | Converts set() into internal cdef _set_value() implementation. |
| grnpy/object.pxd | Exposes _set_value() for cross-module Cython calls and imports grn_id. |
| grnpy/column.pyx | Adds Column.set() delegating to internal _set_value(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+56
| def test_set(tmpdir): | ||
| db_path = tmpdir.join('db') | ||
| with grnpy.Database.create(db_path): | ||
| users = grnpy.Array.create('Users', value_type='Int32') | ||
| id = users.add() | ||
| users.set(id, 29) | ||
|
|
||
| # todo: Add a test for the set value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.