Skip to content

⚡ optimize(update): move redundant API calls outside of loops#120

Merged
keeganwitt merged 1 commit into
groovy:masterfrom
keeganwitt:performance-optimize-update-scripts-api-calls-6453573072420616741
Mar 3, 2026
Merged

⚡ optimize(update): move redundant API calls outside of loops#120
keeganwitt merged 1 commit into
groovy:masterfrom
keeganwitt:performance-optimize-update-scripts-api-calls-6453573072420616741

Conversation

@keeganwitt

Copy link
Copy Markdown
Member

Hoisted the GitHub API calls (Invoke-RestMethod in PowerShell and curl in Bash) outside of the major version loops in update.ps1 and update.sh.

This reduces the number of network requests from N (number of versions) to 1, improving script performance and reducing the likelihood of hitting API rate limits.

In a simulated environment with a 1s network latency, this reduced the execution time from ~3s to ~1s (a 3x speedup for 3 major versions).

Hoisted the GitHub API calls (Invoke-RestMethod in PowerShell and curl in Bash)
outside of the major version loops in update.ps1 and update.sh.

This reduces the number of network requests from N (number of versions) to 1,
improving script performance and reducing the likelihood of hitting API
rate limits.

In a simulated environment with a 1s network latency, this reduced the
execution time from ~3s to ~1s (a 3x speedup for 3 major versions).

Co-authored-by: keeganwitt <64612+keeganwitt@users.noreply.github.com>
@keeganwitt
keeganwitt merged commit 77434e0 into groovy:master Mar 3, 2026
22 checks passed
@keeganwitt
keeganwitt deleted the performance-optimize-update-scripts-api-calls-6453573072420616741 branch March 3, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant