Merged
Conversation
…improve backup age checks
dacharyc
approved these changes
Mar 26, 2026
Collaborator
dacharyc
left a comment
dacharyc
left a comment
There was a problem hiding this comment.
LGTM - thanks for making this safer 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent runaway backup deletion in GDCD BackUpDb
The existing backup logic unconditionally dropped the oldest backup after every copy, which could silently destroy all backups across a partial run or re-run of GDCD.
Skip copy if a recent backup already exists
Before copying, check whether a same-day or prior-day backup exists. If one does, skip the copy entirely. This prevents overwriting the current backup when re-running a job mid-ingest.
Guard the drop with a minimum history check
Before dropping, require both:
With weekly runs, this means the drop won't fire until week 4, after which it maintains a rolling 3-backup window. Clustered re-runs can't trigger the drop because hasRecentBackup blocks new copies from being created.
Refactor: Consolidated duplicate date-parsing logic from findOldestBackup into a shared parseBackupDate helper.