Conversation
9ec5cbf to
f2ab494
Compare
|
@CrazyboyQCD it looks like |
This comment was marked as resolved.
This comment was marked as resolved.
bushrat011899
left a comment
There was a problem hiding this comment.
This is great! Just a couple small suggestions which would help with wgpu/#6826, specifically to get wasm32v1-none
69f3b23 to
aed8dbe
Compare
bushrat011899
left a comment
There was a problem hiding this comment.
Brilliant! I've confirmed this works on wasm32v1-none. One last suggestion: if you apply the below diff, then no_std will also work on native targets, like x86_64-unknown-none:
diff --git a/src/gl46.rs b/src/gl46.rs
index 83d416a..1d259a6 100644
--- a/src/gl46.rs
+++ b/src/gl46.rs
@@ -116,16 +116,7 @@
//! * Individual GL commands are generally safe to use once they've been properly loaded for the current context, but this crate doesn't attempt to sort out what is safe and what's not. All GL commands are blanket marked as being `unsafe`.
//! It's up to you to try and manage this unsafety! Sorry, but this crate just does what you tell it to.
-#[cfg(any(
- all(
- not(feature = "log"),
- any(feature = "debug_trace_calls", feature = "debug_automatic_glGetError")
- ),
- not(feature = "chlorine"),
-))]
-extern crate std;
-
-use std::os::raw::*;
+use core::ffi::*;
#[cfg(feature = "log")]
#[allow(unused)]
bushrat011899
left a comment
There was a problem hiding this comment.
Confirmed working on x86_64-unknown-none!
|
@grovesNL |
Based on #253.