Add support for overriding vertex attribute/semantics#181
Open
aclysma wants to merge 3 commits intogrovesNL:masterfrom
Open
Add support for overriding vertex attribute/semantics#181aclysma wants to merge 3 commits intogrovesNL:masterfrom
aclysma wants to merge 3 commits intogrovesNL:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, spirv-cross assigns the semantic "TEXCOORD#" to vertex input attributes where # is the binding index. I'd like to override these so that the generated HLSL semantic matches up with the names I'm already using to identify vertex attributes (i.e. COLOR or POSITION).
This exposes bindings for the spirv-cross API
CompilerHLSL::add_vertex_attribute_remap.This change includes the changes for #180. I'm happy for them to go in separately or together.