imprv(lsx): Allow spaces in attribute names#10931
Merged
mergify[bot] merged 5 commits intomasterfrom Apr 2, 2026
Merged
Conversation
NJisEverywhere
changed the title
miya
reviewed
Mar 25, 2026
yuki-takei
changed the title
yuki-takei
requested changes
Mar 27, 2026
| } | ||
| prefixParts.push(key); | ||
| } | ||
| attributes.prefix = prefixParts.join(' '); |
Contributor
There was a problem hiding this comment.
case 4 のために、どういったロジックを実装したのかをコード内コメントに書いておいてください
Contributor
There was a problem hiding this comment.
case 4 に対応したテストも一緒に追加する必要がある
Contributor
|
@mergify queue |
Contributor
Merge Queue Status
This pull request spent 10 minutes 43 seconds in the queue, including 10 minutes 29 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
タスク
https://redmine.weseek.co.jp/issues/180325
内容
複数に分割された bare 属性をlsx.ts 側でスペースで結合して prefix を復元する。
after
before
備考
当初はfactory-attributes.js の name() から codes.space を削除することで半角スペースで区切られなくすることを試みたが、既存テストが壊れることが CI で確認されたため方針を変更。