fix: Duplicate user data is appearing in the user table at /user/admin#10940
Merged
yuki-takei merged 1 commit intomasterfrom Mar 27, 2026
Merged
Conversation
miya
commented
Mar 27, 2026
|
|
||
| async resetAllChanges() { | ||
| await this.setState({ | ||
| sort: 'id', |
Member
Author
There was a problem hiding this comment.
バグの原因
デフォルトのソートキーが id でしたが、MongoDB のフィールドは _id で実質ソートなしの状態だった
| sort: 'id', | ||
| sortOrder: 'asc', | ||
| sort: 'createdAt', | ||
| sortOrder: 'desc', |
Member
Author
There was a problem hiding this comment.
修正方針
MongoDB の ObjectId でソートする意味はないと思うので作成日降順でソートする (恣意的かもしれない...)
補足
初回レンダリング時のデフォルトのソートキーが id になっていたが、UI 上からリセット以外で id でソートすることはできない
| const sortOutput = { | ||
| [sort]: sortOrder === 'desc' ? -1 : 1, | ||
| // tiebreaker: ensure stable pagination when the primary sort key has duplicate values | ||
| _id: 1, |
Member
Author
There was a problem hiding this comment.
user.status なのユニーク制約がないものでソートする場合の副次的なキー
yuki-takei
deleted the
fix/180705-duplicate-user-data-is-appearing-in-the-user-table
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
https://redmine.weseek.co.jp/issues/180705