Documentation update#158
Conversation
|
This is a very important task. We also need an example of a |
Agree to refer the attributes as attributes of the "block" Co-authored-by: Théo Rudkiewicz <azertyuiop9216012@gmail.com>
| "SIM102", # forces non-nested if statements | ||
| "SIM108", # leads to decrease the actual coverage | ||
| "SIM117", # nested with statements | ||
| "N802", # function name should be lowercase | ||
| "N803", # argument name should be lowercase | ||
| "N806", # argument name should be lowercase | ||
| "E731", # do not assign a lambda expression, use a def | ||
| "E501", # line too long |
There was a problem hiding this comment.
SIM102, SIM117 seems good rules.
E501 is abit of a pain but may worth it.
There was a problem hiding this comment.
The suggestions from SIM102 and SIM117 seem unreadable to me, but I will leave this to the decision of the majority. E501 was clashing with the pre-commit limit
| def forward(self, x: torch.Tensor) -> torch.Tensor: | ||
| if x.size(1) != self.num_features: | ||
| raise ValueError( | ||
| f"Input size of SizedIdentity must be {self.num_features}, " | ||
| f"but got {input.size(1)}" | ||
| f"but got {x.size(1)}" | ||
| ) | ||
| return super().forward(input) | ||
| return super().forward(x) |
There was a problem hiding this comment.
The problem is that either:
- we don't use
inputas variable - we don't properly inherit from
nn.Modulewhich useinput
Which one is worse is not clear for me. I would go to use input as torch already made this choice but i am not 100% fixed.
There was a problem hiding this comment.
I suggest we use x and suppress any complaints from pytorch
Co-authored-by: Théo Rudkiewicz <azertyuiop9216012@gmail.com>
Co-authored-by: Théo Rudkiewicz <azertyuiop9216012@gmail.com>
TheoRudkiewicz
left a comment
TheoRudkiewicz
left a comment
There was a problem hiding this comment.
Thank you for this huge work. I checked all the code which I know (excluding dag, graph_network and merge modules) and except for the few comments evrything look good.
Co-authored-by: Théo Rudkiewicz <azertyuiop9216012@gmail.com>
…nd config-dependent errors
…r pydoclint DOC502
|
Thank you for contributing everyone! I will now merge this pull request and start a new one to continue this work. 🔥 |
4 participants
TODO:
GrowingDAGSébastian suggestions:
Alex suggestions:
Reminder to address Issues:
*_volumeinGrowingModuleis wrong #153in_features,in_volume,input_shape... #140test_GrowableDAG.py#36