feat(xds-client): gRFC A78 XdsClient metrics + extension point#2669
Open
YutaoMa wants to merge 1 commit into
Open
feat(xds-client): gRFC A78 XdsClient metrics + extension point#2669YutaoMa wants to merge 1 commit into
YutaoMa wants to merge 1 commit into
Conversation
Adds a framework-agnostic `MetricsRecorder` trait (modeled after gRFC
A79) and emits the five A78 XdsClient metrics from the ADS worker:
`grpc.xds_client.{connected, server_failure, resource_updates_valid,
resource_updates_invalid, resources}`. Only `NoOpRecorder` ships in
this PR; a bundled OpenTelemetry implementation is planned for a
follow-up.
Assumes one `XdsClient` instance per channel target; supporting pooled
clients with per-channel attribution would require additional plumbing
(called out in the relevant struct/method docs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ref: #2444
Improve the production readiness of
tonic-xdslibrary by supporting metrics.Solution
This PR builds the foundation for the following metrics-related gRFCs support in
tonic-xds:It adds the following:
MetricsRecordertrait, allowing external users to build any telemetry framework integration they need.grpc.xds_client.{connected, server_failure, resource_updates_valid, resource_updates_invalid, resources}NoOpRecorderas a default fallback.A follow-up PR to add a bundled OpenTelemetry implementation is planned.