Remove runtime go image and replace it with default debian image#403
Merged
paulosjca merged 4 commits intogrpc:masterfrom Mar 27, 2025
Merged
Remove runtime go image and replace it with default debian image#403paulosjca merged 4 commits intogrpc:masterfrom
paulosjca merged 4 commits intogrpc:masterfrom
Conversation
paulosjca
reviewed
Mar 27, 2025
doc/deployment.md
Outdated
| export BUILD_IMAGE_PREFIX=gcr.io/grpc-testing/e2etest/init/build/ | ||
| export RUN_IMAGE_PREFIX=gcr.io/grpc-testing/e2etest/init/runtime/ | ||
| export GOCMD=go1.21.13 | ||
| export TEST_INFRA_VERSION=v1.5.7-pre.1 |
Contributor
There was a problem hiding this comment.
Here it should be just v1.5.7 without -pre.1.
doc/deployment.md
Outdated
| gcr.io/grpc-testing/e2etest/runtime/php7:v1.5.1 | ||
| gcr.io/grpc-testing/e2etest/runtime/python:v1.5.1 | ||
| gcr.io/grpc-testing/e2etest/runtime/ruby:v1.5.1 | ||
| gcr.io/grpc-testing/e2etest/init/build/csharp:v1.5.7 |
Contributor
There was a problem hiding this comment.
Here the location and name of the images has changed.
gcr.io/becomesus-docker.pkg.dev/.init/build/becomesinit-build-.init-becomesinit-.runtime/is removed.
doc/deployment.md
Outdated
| ```shell | ||
| gcr.io/grpc-testing/e2etest/runtime/sidecar:v1.5.1 | ||
| gcr.io/grpc-testing/e2etest/runtime/xds-server:v1.5.1 | ||
| gcr.io/grpc-testing/e2etest/runtime/sidecar:v1.5.7 |
Contributor
There was a problem hiding this comment.
Same location changes apply here too.
6ba1fe0 to
2870786
Compare
paulosjca
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the runtime go image.