Skip to content

Fix main and experimental benchmarks test failure#405

Merged
paulosjca merged 1 commit intogrpc:masterfrom
ajinkyakulkarni75:benchmarks-image-failure
Aug 23, 2025
Merged

Fix main and experimental benchmarks test failure#405
paulosjca merged 1 commit intogrpc:masterfrom
ajinkyakulkarni75:benchmarks-image-failure

Conversation

@ajinkyakulkarni75
Copy link
Copy Markdown
Contributor

Dotnet SDK version is updated in grpc-dotnet, and benchmarks tests are failing.
Updated the SDK version.

@paulosjca paulosjca self-assigned this Aug 23, 2025
@paulosjca paulosjca added the release notes: yes Indicates that PR needs to be in release notes label Aug 23, 2025
Copy link
Copy Markdown
Contributor

@paulosjca paulosjca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve this, since it fixes the issue, but for a complete fix that covers tests that don't use prebuilt images, we should make changes in two other places:

FROM mcr.microsoft.com/dotnet/sdk:9.0-bookworm-slim

FROM mcr.microsoft.com/dotnet/aspnet:9.0-bookworm-slim

@paulosjca paulosjca merged commit 49c24c4 into grpc:master Aug 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: yes Indicates that PR needs to be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants