Open
Conversation
Update mulch to install the JDK rather than the JRE. Add JAVA_HOME to the vagrant user’s environment.
Owner
|
Looks great, but can you update to openjdk 1.8? |
Use the more recent 1.8 JDK, by request of PR grtjn#29.
Owner
|
Sorry, can you fix the set-env too? :-P PS: do you think the JAVA_HOME path will be stable, or should we take extra measure to make sure it won't break at next Java patch release? |
Owner
|
Hi @mariannemyers, I think this is still a useful PR. Do you think you can do a rebase, and have a look at a smarter way for setting JAVA_HOME? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update install-mlcp.sh to install the JDK rather than the JRE. Add JAVA_HOME to
the vagrant user’s environment.