Change the way go fmt is executed#68
Open
gchappel wants to merge 1 commit intogruntwork-io:masterfrom
Open
Conversation
Since `$@` contains a filtered list of all `*.go` files that are staged for the commit, calling `go fmt` on them individually stops the error being thrown when trying to run `go fmt` against a subdirectory, from a directory which does not contain a `go.mod` file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
$@contains a filtered list of all*.gofiles that are staged for the commit, callinggo fmton them individually stops the error being thrown when trying to rungo fmtagainst a subdirectory, from a directory which does not contain ago.modfileDescription
This is one potential workaround for the issue described by me in issue #67
Documentation
TODOs
Please ensure all of these TODOs are completed before asking for a review.
feature/new-vpc-endpoints-955orbug/missing-count-param-434.Related Issues
Fixes #67