Open
Conversation
aug24
force-pushed
the
test-removal-of-nvmrc
branch
from
a227632 to
6d9717c
Compare
aug24
added
the
maintenance
Contributor
aug24
force-pushed
the
test-removal-of-nvmrc
branch
from
ef0aabb to
cfd2592
Compare
aug24
force-pushed
the
test-removal-of-nvmrc
branch
from
cfd2592 to
914d25d
Compare
kelvin-chappell
approved these changes
Mar 18, 2026
Member
kelvin-chappell
left a comment
kelvin-chappell
left a comment
There was a problem hiding this comment.
Looks like it's working 👍
Maybe the PR description should have some rationale for doing this and what might go wrong. But seems unlikely anything will go wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
We would like to standardise on the non-tool-specific tool versions definition file. This appears to be the direction of travel of many/most tools and it keeps our dotfile count down.
In this PR we test complete removal of .nvmrc in favour of .tool-versions, and also of specifying the node-version-file in ci.yaml, to confirm it supports the new location.
How has this change been tested?
How can we measure success?
Have we considered potential risks?
Images
Accessibility