Skip to content

Link follow to notifications in article pages #15558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aracho1 wants to merge 11 commits into
base: main
Choose a base branch
from
+112 −71
Open

Link follow to notifications in article pages #15558

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
47418a6
link follow to notification state
aracho1 Mar 18, 2026
da7f128
remove notification opt out
aracho1 Mar 18, 2026
f10665d
css tweaks
aracho1 Mar 18, 2026
d77d093
auto enable notifications
aracho1 Mar 18, 2026
f3426d2
respect notification settings
aracho1 Mar 18, 2026
6e99ef4
update useEffect
aracho1 Mar 18, 2026
71747ce
move blocklist
aracho1 Mar 19, 2026
bbc206c
Merge branch 'main' into link-follow-to-notifications
aracho1 Mar 19, 2026
fc192bd
remove useState
aracho1 Mar 23, 2026
173218c
Merge branch 'main' into link-follow-to-notifications
aracho1 Mar 25, 2026
2b8b035
Merge branch 'main' into link-follow-to-notifications
aracho1 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
183 changes: 112 additions & 71 deletions dotcom-rendering/src/components/FollowWrapper.island.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,48 @@
import { css } from '@emotion/react';
import { Topic } from '@guardian/bridget/Topic';
import { isUndefined, log } from '@guardian/libs';
import { from, space } from '@guardian/source/foundations';
import { from, space, textSans12 } from '@guardian/source/foundations';
import {
SvgNotificationsOff,
SvgNotificationsOn,
} from '@guardian/source/react-components';
import { useEffect, useState } from 'react';
import { getNotificationsClient, getTagClient } from '../lib/bridgetApi';
import { useIsBridgetCompatible } from '../lib/useIsBridgetCompatible';
import { useIsMyGuardianEnabled } from '../lib/useIsMyGuardianEnabled';
import { FollowNotificationsButton, FollowTagButton } from './FollowButtons';
import { palette as schemedPalette } from '../palette';
import { FollowTagButton } from './FollowButtons';

type Props = {
id: string;
displayName: string;
};

const notificationTextStyles = css`
${textSans12}
color: ${schemedPalette('--follow-text')};
fill: currentColor;
display: flex;
align-items: center;
column-gap: ${space[1]}px;
min-height: ${space[6]}px;
padding: 0;
`;

const blockList = ['profile/anas-al-sharif'];

export const FollowWrapper = ({ id, displayName }: Props) => {
const [isFollowingNotifications, setIsFollowingNotifications] = useState<
boolean | undefined
>(undefined);
const [isFollowingTag, setIsFollowingTag] = useState<boolean | undefined>(
undefined,
);
const [showFollowTagButton, setShowFollowTagButton] =
useState<boolean>(false);

const isMyGuardianEnabled = useIsMyGuardianEnabled();
const isBridgetCompatible = useIsBridgetCompatible('2.5.0');

const isNotInBlockList = (tagId: string) => {
const blockList = ['profile/anas-al-sharif'];
return !blockList.includes(tagId);
};

if (isBridgetCompatible && isMyGuardianEnabled && isNotInBlockList(id)) {
setShowFollowTagButton(true);
}
const showFollowTagButton =
isBridgetCompatible && isMyGuardianEnabled && !blockList.includes(id);

useEffect(() => {
const topic = new Topic({
Expand All @@ -42,31 +51,62 @@ export const FollowWrapper = ({ id, displayName }: Props) => {
type: 'tag-contributor',
});

void getNotificationsClient()
.isFollowing(topic)
.then(setIsFollowingNotifications)
.catch((error) => {
window.guardian.modules.sentry.reportError(
error,
'bridget-getNotificationsClient-isFollowing-error',
);
log(
'dotcom',
'Bridget getNotificationsClient.isFollowing Error:',
error,
);
});
void Promise.all([
getNotificationsClient()
.isFollowing(topic)
.catch((error) => {
window.guardian.modules.sentry.reportError(
error,
'bridget-getNotificationsClient-isFollowing-error',
);
log(
'dotcom',
'Bridget getNotificationsClient.isFollowing Error:',
error,
);
return undefined;
}),
getTagClient()
.isFollowing(topic)
.catch((error) => {
window.guardian.modules.sentry.reportError(
error,
'bridget-getTagClient-isFollowing-error',
);
log(
'dotcom',
'Bridget getTagClient.isFollowing Error:',
error,
);
return undefined;
}),
]).then(([followingNotifications, followingTag]) => {
setIsFollowingNotifications(followingNotifications);
setIsFollowingTag(followingTag);

void getTagClient()
.isFollowing(topic)
.then(setIsFollowingTag)
.catch((error) => {
window.guardian.modules.sentry.reportError(
error,
'bridget-getTagClient-isFollowing-error',
);
log('dotcom', 'Bridget getTagClient.isFollowing Error:', error);
});
// Legacy: if user has notifications on but isn't following,
// auto-follow the tag to keep states consistent
if (followingNotifications && !followingTag) {
void getTagClient()
.follow(topic)
.then((success) => {
if (success) {
setIsFollowingTag(true);
}
})
.catch((error) => {
window.guardian.modules.sentry.reportError(
error,
'bridget-getTagClient-auto-follow-error',
Copy link
Copy Markdown
Contributor Author

@aracho1 aracho1 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've assumed it's ok to create a new Sentry error type for this but please let me know if I should just use an existing one e.g. `'bridget-getTagClient-isFollowing-error'

);
log(
'dotcom',
'Bridget getTagClient.follow (auto) Error:',
error,
);
});
}
});
}, [id, displayName]);

const tagHandler = () => {
Expand Down Expand Up @@ -95,32 +135,8 @@ export const FollowWrapper = ({ id, displayName }: Props) => {
error,
);
});
} else {
void getTagClient()
.follow(topic)
.then((success) => {
if (success) {
setIsFollowingTag(true);
}
})
.catch((error) => {
window.guardian.modules.sentry.reportError(
error,
'bridget-getTagClient-follow-error',
);
log('dotcom', 'Bridget getTagClient.follow Error:', error);
});
}
};

const notificationsHandler = () => {
const topic = new Topic({
id,
displayName,
type: 'tag-contributor',
});

if (isFollowingNotifications) {
// Turn off notifications when unfollowing
void getNotificationsClient()
.unfollow(topic)
.then((success) => {
Expand All @@ -131,7 +147,7 @@ export const FollowWrapper = ({ id, displayName }: Props) => {
.catch((error) => {
window.guardian.modules.sentry.reportError(
error,
'briidget-getNotificationsClient-unfollow-error',
'bridget-getNotificationsClient-unfollow-error',
);
log(
'dotcom',
Expand All @@ -140,6 +156,22 @@ export const FollowWrapper = ({ id, displayName }: Props) => {
);
});
} else {
void getTagClient()
.follow(topic)
.then((success) => {
if (success) {
setIsFollowingTag(true);
}
})
.catch((error) => {
window.guardian.modules.sentry.reportError(
error,
'bridget-getTagClient-follow-error',
);
log('dotcom', 'Bridget getTagClient.follow Error:', error);
});

// Enable notifications when following
void getNotificationsClient()
.follow(topic)
.then((success) => {
Expand Down Expand Up @@ -189,14 +221,23 @@ export const FollowWrapper = ({ id, displayName }: Props) => {
withExtraBottomMargin={true}
/>
)}
<FollowNotificationsButton
isFollowing={isFollowingNotifications ?? false}
onClickHandler={
!isUndefined(isFollowingNotifications)
? notificationsHandler
: () => undefined
}
/>
{isFollowingTag && (
<span css={notificationTextStyles}>
{isFollowingNotifications ? (
<>
<SvgNotificationsOn size="small" />
Notifications turned on. Turn off anytime in
Settings.
</>
) : (
<>
<SvgNotificationsOff size="small" />
Notifications turned off. Turn on anytime in
Settings.
</>
)}
</span>
)}
</div>
);
};
Loading