Skip to content

Prevent showing branding on front containers without branding type label#15604

Merged
cemms1 merged 1 commit intomainfrom
cemms1/fix-brand-logo-in-front-container
Mar 27, 2026
Merged

Prevent showing branding on front containers without branding type label#15604
cemms1 merged 1 commit intomainfrom
cemms1/fix-brand-logo-in-front-container

Conversation

@cemms1
Copy link
Contributor

@cemms1 cemms1 commented Mar 27, 2026

What does this change?

Omits the brand logo from containers which contain branded content from the same brand but do not have the Labs styling applied (ie. do not have the Branded tag)

Why?

We don't want to display branding without any other visual information to explain why the branding is there. This is usually indicated by the branding label e.g "Paid for by"

This scenario usually doesn't happen in practice because branded containers usually have the Branded label applied to them which results in Labs branding

Screenshots

The following screenshots are of a container where all cards represent paid content from the same brand. Usually the Branded tag would be applied in the fronts tool to convert it into a Labs-styled container, but in case this is omitted, this is what the result would look like:

Before After
before after

@cemms1 cemms1 added fix Departmental tracking: fix Commercial 💰 run_chromatic Runs chromatic when label is applied labels Mar 27, 2026
@cemms1 cemms1 marked this pull request as ready for review March 27, 2026 11:39
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Mar 27, 2026
@cemms1 cemms1 requested a review from a team March 27, 2026 11:45
Copy link
Member

@Jakeii Jakeii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense this is what's done for the sponsored type below, so am I right in saying that the only situation a logo should appear without labs styling is for theguardian.org/foundation branding?

@cemms1
Copy link
Contributor Author

cemms1 commented Mar 27, 2026

Makes sense this is what's done for the sponsored type below, so am I right in saying that the only situation a logo should appear without labs styling is for theguardian.org/foundation branding?

We do need to document what happens at the moment a little better, but here's some screenshots to demonstrate the case at the moment:

Paid content

Guardian Labs

Screenshot Link
Guardian Labs - container link
Guardian Labs - front link

Where Guardian Labs styling is applied to the whole front, the front containers do not take Labs styling as this is applied at the page level. In this case, the branding is applied to a standard front container

Paid content but NOT Guardian Labs

We do not have paid content without labs branding unless it is classed as an advertising partner or exclusive deal. I can't find any examples of this in the wild but here's a storybook link to demonstrate the styling https://main--63e251470cfbe61776b0ef19.chromatic.com/iframe.html?id=components-frontsection--with-sponsored-branding-advertising-partner&viewMode=story&globals=viewport.value%3AdoesNotExist
image

The following screenshots are from the PR description and only apply when there is branding associated with the container but it has not been classified as a labs container or full page branding

Screenshot Link
Paid content, not labs (before) link
Paid content, not labs (after) link

Sponsored content

I can't find any real world examples of this, so this is from Storybook

Screenshot Link
Sponsored container link
Sponsored front link

Guardian Foundation

Screenshot Link
Foundation funded container* link
Foundation funded front link
  • It's debatable whether we want branding to appear in this scenario. The requirements on this are hard to understand

@cemms1 cemms1 merged commit 86e460f into main Mar 27, 2026
38 checks passed
@cemms1 cemms1 deleted the cemms1/fix-brand-logo-in-front-container branch March 27, 2026 15:26
@gu-prout
Copy link

gu-prout bot commented Mar 27, 2026

Seen on PROD (merged by @cemms1 7 minutes and 53 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Commercial 💰 fix Departmental tracking: fix Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants