Prevent banner vertical scrollbar by removing height constraint and adding proper margin#15605
Merged
Prevent banner vertical scrollbar by removing height constraint and adding proper margin#15605
Conversation
…ner components Remove inconsistent margin and padding values, implement consistent flexbox centering, and consolidate tablet breakpoint styles. Apply identical styling to DesignableBanner, v2/Banner, and v2/BannerVisual components for visual consistency.
juabara
added
run_chromatic
github-actions
bot
removed
the
run_chromatic
…l containers at desktop breakpoint
Remove `height: 100%` from tablet breakpoint and add `margin: ${space[6]}px 0` at desktop breakpoint for visual container styling. Apply changes consistently across DesignableBanner, v2/Banner, and v2/BannerVisual components.
juabara
changed the title
juabara
changed the title
github-actions
bot
removed
the
run_chromatic
tomrf1
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a vertical scrollbar issue in banner components caused by large images exceeding the container height.
Problem solved:
height: 100%constraint at tablet breakpoint was forcing content to overflowChanges made:
height: 100%constraint from tablet breakpoint to allow natural content heightmargin: ${space[6]}px 0at desktop breakpoint for proper vertical spacingDesignableBannercomponentv2/Bannercomponentv2/BannerVisualcomponentThis ensures banner visuals display properly without causing unwanted vertical scrollbars when images are larger than the container.