Merged
Conversation
Author
There was a problem hiding this comment.
Polyfill! Can be removed if ded/bonzo#133 goes through
Contributor
There was a problem hiding this comment.
Maybe but a @* *@ comment above this to say why it is here.
Contributor
|
👍 Thanks for doing this, seems like it was quite a pain. |
Author
|
Also not, reason we're not seeing these IE errors in sentry is because they're thrown in |
ironsidevsquincy
pushed a commit
that referenced
this pull request
Aug 18, 2014
Greater browser support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, get ads to work in IE8. Bulk of the work was moving away from using the cool native array functions, which don't exist, to lodash
Also, now using proper qwery, not the mobile variant
However, still doesn't work due to an issue in reqwest